languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ VM / Service ] Updated JSONWriter::PrintValue(double) to use double_conversion instead of Printf.

Browse source 
Fixes #31737

Change-Id: If70b7b6bdd1e977bda310a2b0566dcd48c6b3c6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101101
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ben Konyi 2019-05-03 18:07:27 +00:00 committed by commit-bot@chromium.org
parent 58ef1db2ba
commit bdc91968a2
3 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/vm/json_test.cc
View file

@ -61,7 +61,7 @@ TEST_CASE(JSON_JSONStream_Primitives) {
JSONArray jsarr(&js);
jsarr.AddValue(1.0);
}
EXPECT_STREQ("[1.000000]", js.ToCString());
EXPECT_STREQ("[1.0]", js.ToCString());
}
{
JSONStream js;

8
runtime/vm/json_writer.cc
View file

@ -5,6 +5,7 @@
#include "platform/assert.h"
#include "platform/unicode.h"
#include "vm/double_conversion.h"
#include "vm/json_writer.h"
#include "vm/object.h"
@ -117,8 +118,13 @@ void JSONWriter::PrintValue64(int64_t i) {
}
void JSONWriter::PrintValue(double d) {
// Max length of a double in characters (including \0).
// See double_conversion.cc.
const size_t kBufferLen = 25;
char buffer[kBufferLen];
DoubleToCString(d, buffer, kBufferLen);
PrintCommaIfNeeded();
buffer_.Printf("%f", d);
buffer_.Printf("%s", buffer);
}
static const char base64_digits[65] =

2
runtime/vm/metrics_test.cc
View file

@ -67,7 +67,7 @@ VM_UNIT_TEST_CASE(Metric_OnDemand) {
"{\"type\":\"Counter\",\"name\":\"a.b.c\",\"description\":"
"\"foobar\",\"unit\":\"byte\","
"\"fixedId\":true,\"id\":\"metrics\\/native\\/a.b.c\""
",\"value\":99.000000}",
",\"value\":99.0}",
json);
}
Dart_ShutdownIsolate();