languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:19:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix npe in quick fix computation (issue 32926)

Browse source 
Change-Id: Ic93da063758513f101d753516cb61c351dae2501
Reviewed-on: https://dart-review.googlesource.com/51940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Danny Tuppeny <dantup@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Brian Wilkerson 2018-04-19 17:05:20 +00:00 committed by commit-bot@chromium.org
parent 499b6ba4cf
commit bdc727d49b
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/analysis_server/lib/src/services/correction/fix_internal.dart
View file

@ -2393,7 +2393,7 @@ class FixProcessor {
final thisExpression = node is ThisExpression
? node
: node.getAncestor((node) => node is ThisExpression);
final parent = thisExpression.parent;
final parent = thisExpression?.parent;
if (parent is PropertyAccess) {
DartChangeBuilder changeBuilder = new DartChangeBuilder(session);
await changeBuilder.addFileEdit(file, (DartFileEditBuilder builder) {

11
pkg/analysis_server/test/services/correction/fix_test.dart
View file

@ -6901,6 +6901,17 @@ class A {
''');
}
test_removeThisExpression_notAThisExpression() async {
String src = '''
void foo() {
final /*LINT*/this.id;
}
''';
await findLint(src, LintNames.unnecessary_this);
await assertNoFix(DartFixKind.REMOVE_THIS_EXPRESSION);
}
test_removeThisExpression_propertyAccess_oneCharacterOperator() async {
String src = '''
class A {