languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart2wasm] Fix block type of unimplemented

Browse source 
The test co19/Language/Libraries_and_Scripts/Imports/static_type_t01 now
fails with "unreachable" in runtime as expected (instead of compile
time crash).

Change-Id: Ia311485b3eefcde2d07d67b473238129dad69cce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263580
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
This commit is contained in:
Ömer Sinan Ağacan 2022-10-12 07:10:46 +00:00 committed by Commit Queue
parent 48f33cc37a
commit bc46593d5d
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/dart2wasm/lib/code_generator.dart
View file

@ -125,7 +125,8 @@ class CodeGenerator extends ExpressionVisitor1<w.ValueType, w.ValueType>
@override
w.ValueType defaultExpression(Expression node, w.ValueType expectedType) {
unimplemented(node, node.runtimeType, [expectedType]);
unimplemented(
node, node.runtimeType, [if (expectedType != voidMarker) expectedType]);
return expectedType;
}