languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-05 18:22:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Address review comments from 150935

Browse source 
Change-Id: Ia137c8c139e13cb9b3f8017328f5a79edfcbc0b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151022
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This commit is contained in:
Stephen Adams 2020-06-12 05:54:28 +00:00 committed by commit-bot@chromium.org
parent c1f0bc310d
commit bbeda37c05
3 changed files with 6 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/compiler/lib/src/ir/static_type.dart
View file

@ -1943,10 +1943,10 @@ class TypeMap {
if (newTypesOfInterest.length > 1 ||
(newTypesOfInterest.length == 1 &&
newTypesOfInterest.single != info.declaredType)) {
// If [newTypesOfInterest] only contains the we have no information
// about the variable (it is either an instance of its declared type
// or null) and the canonical way to represent this is to have _no_
// target info.
// If [newTypesOfInterest] only contains the declared type we have no
// information about the variable (it is either an instance of its
// declared type or null) and the canonical way to represent this is
// to have _no_ target info.
TypeHolder typeHolderIfNonNull =
new TypeHolder(info.declaredType, newTypesOfInterest, null);
TypeHolder typeHolderIfNull = new TypeHolder(info.declaredType, null,

11
tests/dart2js/regress_42281_test.dart
View file

@ -25,7 +25,7 @@ ComponentFactory? test(String s, [Map<String, ComponentFactory>? mf2]) {
return f;
}
work() {
main() {
Map<String, ComponentFactory> mf2 = {'int': ComponentFactory<num>()};
test('String');
@ -35,12 +35,3 @@ work() {
test('RegExp');
test('RegExp', mf2);
}
main() {
try {
work();
} catch (e, st) {
print(e);
print(st);
}
}

11
tests/dart2js_2/regress_42281_test.dart
View file

@ -25,7 +25,7 @@ ComponentFactory test(String s, [Map<String, ComponentFactory> mf2]) {
return f;
}
work() {
main() {
Map<String, ComponentFactory> mf2 = {'int': ComponentFactory<num>()};
test('String');
@ -35,12 +35,3 @@ work() {
test('RegExp');
test('RegExp', mf2);
}
main() {
try {
work();
} catch (e, st) {
print(e);
print(st);
}
}