languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 12:47:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

[nnbd_migration] Fix #41338, top code reference in details now a link

Browse source 
Change-Id: If93956ef4065582bee9afdff783358870e18e16c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146701
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
This commit is contained in:
Mike Fairhurst 2020-05-05 21:47:13 +00:00 committed by commit-bot@chromium.org
parent 9bba7323a0
commit ba6725d547
2 changed files with 3623 additions and 3649 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7266
pkg/nnbd_migration/lib/src/front_end/resources/resources.g.dart
View file

File diff suppressed because it is too large Load diff

6
pkg/nnbd_migration/lib/src/front_end/web/migration.dart
View file

@ -533,7 +533,11 @@ void populateEditDetails([EditDetails response]) {
var line = response.line;
Element explanation = document.createElement('p');
editPanel.append(explanation);
explanation.append(Text('$explanationMessage at $relPath:$line.'));
explanation
..appendText('$explanationMessage at ')
..append(AnchorElement(
href: pathWithQueryParameters(filePath, {'line': line.toString()}))
..appendText('$relPath:$line.'));
explanation.scrollIntoView();
_populateEditTraces(response, editPanel, parentDirectory);
_populateEditLinks(response, editPanel);