languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 17:59:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart2wasm] Simplify native ByteBuffer implmenetation view conversions

Browse source 
After checking alignment of the offset we know that it's aligned (as the
check throws otherwise), so we return the fast view class without
checking the alignment again.

Change-Id: I11e64cf867da8a837e6087ee6548cc509e686ab7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336360
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
This commit is contained in:
Ömer Sinan Ağacan 2023-11-15 11:41:15 +00:00 committed by Commit Queue
parent bf587fbb71
commit ba596c51a3
1 changed files with 16 additions and 55 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

71
sdk/lib/_internal/wasm/lib/typed_data.dart
View file

@ -1168,13 +1168,8 @@ class _I16ByteBuffer extends ByteBufferBase {
_rangeCheck(
lengthInBytes, offsetInBytes, length * Int16List.bytesPerElement);
_offsetAlignmentCheck(offsetInBytes, Int16List.bytesPerElement);
if (offsetInBytes % Int16List.bytesPerElement != 0) {
return _SlowI16List._withMutability(
this, offsetInBytes, length, _mutable);
} else {
return I16List._withMutability(
_data, offsetInBytes ~/ Int16List.bytesPerElement, length, _mutable);
}
return I16List._withMutability(
_data, offsetInBytes ~/ Int16List.bytesPerElement, length, _mutable);
}
@override
@ -1183,13 +1178,8 @@ class _I16ByteBuffer extends ByteBufferBase {
_rangeCheck(
lengthInBytes, offsetInBytes, length * Uint16List.bytesPerElement);
_offsetAlignmentCheck(offsetInBytes, Uint16List.bytesPerElement);
if (offsetInBytes % Uint16List.bytesPerElement != 0) {
return _SlowU16List._withMutability(
this, offsetInBytes, length, _mutable);
} else {
return U16List._withMutability(
_data, offsetInBytes ~/ Uint16List.bytesPerElement, length, _mutable);
}
return U16List._withMutability(
_data, offsetInBytes ~/ Uint16List.bytesPerElement, length, _mutable);
}
@override
@ -1220,13 +1210,8 @@ class _I32ByteBuffer extends ByteBufferBase {
_rangeCheck(
lengthInBytes, offsetInBytes, length * Int32List.bytesPerElement);
_offsetAlignmentCheck(offsetInBytes, Int32List.bytesPerElement);
if (offsetInBytes % Uint32List.bytesPerElement != 0) {
return _SlowI32List._withMutability(
this, offsetInBytes, length, _mutable);
} else {
return I32List._withMutability(
_data, offsetInBytes ~/ Int32List.bytesPerElement, length, _mutable);
}
return I32List._withMutability(
_data, offsetInBytes ~/ Int32List.bytesPerElement, length, _mutable);
}
@override
@ -1235,13 +1220,8 @@ class _I32ByteBuffer extends ByteBufferBase {
_rangeCheck(
lengthInBytes, offsetInBytes, length * Uint32List.bytesPerElement);
_offsetAlignmentCheck(offsetInBytes, Uint32List.bytesPerElement);
if (offsetInBytes % Uint32List.bytesPerElement != 0) {
return _SlowU32List._withMutability(
this, offsetInBytes, length, _mutable);
} else {
return U32List._withMutability(
_data, offsetInBytes ~/ Uint32List.bytesPerElement, length, _mutable);
}
return U32List._withMutability(
_data, offsetInBytes ~/ Uint32List.bytesPerElement, length, _mutable);
}
@override
@ -1272,13 +1252,8 @@ class _I64ByteBuffer extends ByteBufferBase {
_rangeCheck(
lengthInBytes, offsetInBytes, length * Int64List.bytesPerElement);
_offsetAlignmentCheck(offsetInBytes, Int64List.bytesPerElement);
if (offsetInBytes % Int64List.bytesPerElement != 0) {
return _SlowI64List._withMutability(
this, offsetInBytes, length, _mutable);
} else {
return I64List._withMutability(
_data, offsetInBytes ~/ Int64List.bytesPerElement, length, _mutable);
}
return I64List._withMutability(
_data, offsetInBytes ~/ Int64List.bytesPerElement, length, _mutable);
}
@override
@ -1287,13 +1262,8 @@ class _I64ByteBuffer extends ByteBufferBase {
_rangeCheck(
lengthInBytes, offsetInBytes, length * Uint64List.bytesPerElement);
_offsetAlignmentCheck(offsetInBytes, Uint64List.bytesPerElement);
if (offsetInBytes % Int64List.bytesPerElement != 0) {
return _SlowU64List._withMutability(
this, offsetInBytes, length, _mutable);
} else {
return U64List._withMutability(
_data, offsetInBytes ~/ Uint64List.bytesPerElement, length, _mutable);
}
return U64List._withMutability(
_data, offsetInBytes ~/ Uint64List.bytesPerElement, length, _mutable);
}
@override
@ -1324,13 +1294,8 @@ class _F32ByteBuffer extends ByteBufferBase {
_rangeCheck(
lengthInBytes, offsetInBytes, length * Float32List.bytesPerElement);
_offsetAlignmentCheck(offsetInBytes, Float32List.bytesPerElement);
if (offsetInBytes % Float32List.bytesPerElement != 0) {
return _SlowF32List._withMutability(
this, offsetInBytes, length, _mutable);
} else {
return F32List._withMutability(_data,
offsetInBytes ~/ Float32List.bytesPerElement, length, _mutable);
}
return F32List._withMutability(
_data, offsetInBytes ~/ Float32List.bytesPerElement, length, _mutable);
}
@override
@ -1361,12 +1326,8 @@ class _F64ByteBuffer extends ByteBufferBase {
_rangeCheck(
lengthInBytes, offsetInBytes, length * Float64List.bytesPerElement);
_offsetAlignmentCheck(offsetInBytes, Float64List.bytesPerElement);
if (offsetInBytes % Float64List.bytesPerElement != 0) {
return SlowF64List._withMutability(this, offsetInBytes, length, _mutable);
} else {
return F64List._withMutability(
_data, offsetInBytes ~/ Int64List.bytesPerElement, length, _mutable);
}
return F64List._withMutability(
_data, offsetInBytes ~/ Int64List.bytesPerElement, length, _mutable);
}
@override