languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 15:21:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ddc] Don't emit null arg checks in sound mode

Browse source 
Compiled output for sound null safety mode no longer needs to check
non-nullable arguments for null.

They can't be null since we no longer allow mixed opt-in/out libraries
when running with sound null safety.

Cleanup a repeated string in the SDK.

Change-Id: Ib7ae86f04660857957b4a7590bc5a7efd2c3fa04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154848
Reviewed-by: Mark Zhou <markzipan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
This commit is contained in:
Nicholas Shahan 2020-07-20 22:04:19 +00:00 committed by commit-bot@chromium.org
parent e75dca3d2e
commit b8c2cd49df
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/dev_compiler/lib/src/kernel/compiler.dart
View file

@ -3239,7 +3239,8 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
if (_annotatedNullCheck(p.annotations)) {
body.add(_nullParameterCheck(jsParam));
} else if (_mustBeNonNullable(p.type) &&
} else if (!_options.soundNullSafety &&
_mustBeNonNullable(p.type) &&
!_annotatedNotNull(p.annotations)) {
// TODO(vsm): Remove if / when CFE does this:
// https://github.com/dart-lang/sdk/issues/40597

15
sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart
View file

@ -25,22 +25,21 @@ assertFailed(String? message,
}
final _nullFailedSet = JS('!', 'new Set()');
String _nullFailedMessage(variableName) =>
'A null value was passed into a non-nullable parameter: $variableName.';
// Run-time null safety assertion per:
// https://github.com/dart-lang/language/blob/master/accepted/future-releases/nnbd/feature-specification.md#automatic-debug-assertion-insertion
nullFailed(String? fileUri, int? line, int? column, String? variable) {
if (_nonNullAsserts) {
throw AssertionErrorImpl(
'A null value was passed into a non-nullable parameter $variable',
fileUri,
line,
column,
'$variable != null');
throw AssertionErrorImpl(_nullFailedMessage(variable), fileUri, line,
column, '$variable != null');
}
var key = '$fileUri:$line:$column';
if (!JS('!', '#.has(#)', _nullFailedSet, key)) {
JS('', '#.add(#)', _nullFailedSet, key);
_nullWarn(
'A null value was passed into a non-nullable parameter $variable');
_nullWarn(_nullFailedMessage(variable));
}
}