From b8b67c066ceec199a774e5acf55dd3e350834976 Mon Sep 17 00:00:00 2001 From: Parker Lougheed Date: Fri, 1 Dec 2023 17:32:48 +0000 Subject: [PATCH] [cfe] Correct PrivateNamedParameter problem message Named parameters can't start with underscores whether they are optional or required. Change-Id: Iaaeab80f74a691b4981148f06412a60ca115f73e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337883 Auto-Submit: Parker Lougheed Reviewed-by: Paul Berry Commit-Queue: Paul Berry Reviewed-by: Johnni Winther --- pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart | 3 ++- pkg/front_end/messages.yaml | 2 +- tests/language/parameter/initializer6_test.dart | 3 +-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart b/pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart index 4ca832bb8f1..bb994979f79 100644 --- a/pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart +++ b/pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart @@ -12369,7 +12369,8 @@ const Code codePrivateNamedParameter = messagePrivateNamedParameter; const MessageCode messagePrivateNamedParameter = const MessageCode( "PrivateNamedParameter", analyzerCodes: ["PRIVATE_OPTIONAL_PARAMETER"], - problemMessage: r"""An optional named parameter can't start with '_'."""); + problemMessage: + r"""A named parameter can't start with an underscore ('_')."""); // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE. const Code codeRecordFieldsCantBePrivate = diff --git a/pkg/front_end/messages.yaml b/pkg/front_end/messages.yaml index e58391926ce..d265600da41 100644 --- a/pkg/front_end/messages.yaml +++ b/pkg/front_end/messages.yaml @@ -1995,7 +1995,7 @@ FunctionTypeDefaultValue: analyzerCode: DEFAULT_VALUE_IN_FUNCTION_TYPE PrivateNamedParameter: - problemMessage: "An optional named parameter can't start with '_'." + problemMessage: "A named parameter can't start with an underscore ('_')." analyzerCode: PRIVATE_OPTIONAL_PARAMETER NoFormals: diff --git a/tests/language/parameter/initializer6_test.dart b/tests/language/parameter/initializer6_test.dart index b711a866587..f3b9885e178 100644 --- a/tests/language/parameter/initializer6_test.dart +++ b/tests/language/parameter/initializer6_test.dart @@ -11,8 +11,7 @@ class Foo { Foo.private({this._y = 77}) {} // ^^ // [analyzer] COMPILE_TIME_ERROR.PRIVATE_OPTIONAL_PARAMETER - // ^ - // [cfe] An optional named parameter can't start with '_'. + // [cfe] A named parameter can't start with an underscore ('_'). } main() {