From b6c8bd7a81d3a71a0e57a152626538012396823f Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Thu, 21 Jul 2022 10:22:45 +0000 Subject: [PATCH] [gardening] Mark all tests as slow in debug-ia32 mode On ia32 the CFE will run from a kernel file instead of an AppJit snapshot. This is generally not that fast. In debug mode the JIT will have various additional verifications turned on in the runtime (e.g. flow graph checker runs, ...) - which will make it very slow. So we should give all tests on debug-ia32 extra time. TEST=ci Change-Id: Ia2738a38c5cb50a4e830af23f663f205ab4c6593 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252360 Reviewed-by: Tess Strickland Commit-Queue: Martin Kustermann --- tests/language/language_kernel.status | 4 +++- tests/language_2/language_2_kernel.status | 4 +++- tests/lib/lib_kernel.status | 3 +++ tests/lib_2/lib_2_kernel.status | 3 +++ 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/language/language_kernel.status b/tests/language/language_kernel.status index acd118f031b..1edee47e04c 100644 --- a/tests/language/language_kernel.status +++ b/tests/language/language_kernel.status @@ -2,7 +2,6 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. - [ $compiler == app_jitk ] main/no_main_test/01: Crash number/web_int_literals_test/*: SkipByDesign # Test applies only to JavaScript targets @@ -203,6 +202,9 @@ nnbd/syntax/class_member_declarations_test/none: Skip # Issue 39823 nnbd/syntax/nullable_type_test: Skip # Issue 39820 nnbd/syntax/opt_out_nnbd_modifiers_test: Skip # Issue 37957 +[ $arch == ia32 && $mode == debug ] +*: Pass, Slow # The CFE is not run from AppJit snapshot, JIT warmup in debug mode very slow + [ $builder_tag == obfuscated && $compiler == dartkp ] generic/function_dcall_test/01: SkipByDesign # Prints type names mixin/generic_test: SkipByDesign # Prints type names diff --git a/tests/language_2/language_2_kernel.status b/tests/language_2/language_2_kernel.status index 1db04b4e219..eac0760d6b9 100644 --- a/tests/language_2/language_2_kernel.status +++ b/tests/language_2/language_2_kernel.status @@ -2,7 +2,6 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. - [ $compiler == app_jitk ] main/no_main_test/01: Crash number/web_int_literals_test/*: SkipByDesign # Test applies only to JavaScript targets @@ -27,6 +26,9 @@ superinterface_variance/mixin_error_test/46: Crash # Issue dart-lang/language#11 superinterface_variance/mixin_error_test/47: Crash # Issue dart-lang/language#113 superinterface_variance/mixin_error_test/48: Crash # Issue dart-lang/language#113 +[ $arch == ia32 && $mode == debug ] +*: Pass, Slow # The CFE is not run from AppJit snapshot, JIT warmup in debug mode very slow + [ $builder_tag == obfuscated && $compiler == dartkp ] generic/function_dcall_test/01: SkipByDesign # Prints type names mixin/generic_test: SkipByDesign # Prints type names diff --git a/tests/lib/lib_kernel.status b/tests/lib/lib_kernel.status index 20fb8dc2594..050cea871ba 100644 --- a/tests/lib/lib_kernel.status +++ b/tests/lib/lib_kernel.status @@ -10,6 +10,9 @@ isolate/ping_pause_test: Skip # Issue https://dartbug.com/37787 html/*: Skip # TODO(ahe): Make dart:html available. js/*: Skip # TODO(ahe): Make dart:js available. +[ $arch == ia32 && $mode == debug ] +*: Pass, Slow # The CFE is not run from AppJit snapshot, JIT warmup in debug mode very slow + [ $arch == x64 && $compiler == dartk && $mode == debug && $runtime == vm ] mirrors/invocation_fuzz_test: Skip # Because it times out, issue 29439. diff --git a/tests/lib_2/lib_2_kernel.status b/tests/lib_2/lib_2_kernel.status index 20fb8dc2594..050cea871ba 100644 --- a/tests/lib_2/lib_2_kernel.status +++ b/tests/lib_2/lib_2_kernel.status @@ -10,6 +10,9 @@ isolate/ping_pause_test: Skip # Issue https://dartbug.com/37787 html/*: Skip # TODO(ahe): Make dart:html available. js/*: Skip # TODO(ahe): Make dart:js available. +[ $arch == ia32 && $mode == debug ] +*: Pass, Slow # The CFE is not run from AppJit snapshot, JIT warmup in debug mode very slow + [ $arch == x64 && $compiler == dartk && $mode == debug && $runtime == vm ] mirrors/invocation_fuzz_test: Skip # Because it times out, issue 29439.