From b5d53b5348cf8aad8a63b6414374bc07584b03a3 Mon Sep 17 00:00:00 2001 From: Jacob Richman Date: Tue, 28 Mar 2017 08:30:10 -0700 Subject: [PATCH] Fix spew when running presubmit which triggers dartfmt.bat on windows. We should also backport this change to the sdks in tools/sdk or roll a new version of the tools/sdk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Error span you otherwise get with each dartfmt invocation: find: ‘> bin [’: No such file or directory Note that the error doesn't occur all times dartfmt is run, only when it is run from the directory triggered by the presubmit. BUG= R=rnystrom@google.com, whesse@google.com Review-Url: https://codereview.chromium.org/2759333004 . --- sdk/bin/dart2js.bat | 2 +- sdk/bin/dart2js_sdk.bat | 2 +- sdk/bin/dartanalyzer.bat | 2 +- sdk/bin/dartanalyzer_sdk.bat | 2 +- sdk/bin/dartdevc.bat | 2 +- sdk/bin/dartdoc.bat | 2 +- sdk/bin/dartfmt.bat | 2 +- sdk/bin/pub.bat | 2 +- sdk/bin/pub_sdk.bat | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/sdk/bin/dart2js.bat b/sdk/bin/dart2js.bat index 76601828b70..c0786608c9a 100644 --- a/sdk/bin/dart2js.bat +++ b/sdk/bin/dart2js.bat @@ -50,7 +50,7 @@ setlocal for %%i in (%1) do set result=%%~fi set current= for /f "usebackq tokens=2 delims=[]" %%i in (`dir /a:l "%~dp1" 2^>nul ^ - ^| %SystemRoot%\System32\find.exe "> %~n1 ["`) do ( + ^| %SystemRoot%\System32\find.exe "> %~n1 [" 2^>nul`) do ( set current=%%i ) if not "%current%"=="" call :follow_links "%current%", result diff --git a/sdk/bin/dart2js_sdk.bat b/sdk/bin/dart2js_sdk.bat index 696c713b3b6..9f01c0f8da0 100755 --- a/sdk/bin/dart2js_sdk.bat +++ b/sdk/bin/dart2js_sdk.bat @@ -47,7 +47,7 @@ setlocal for %%i in (%1) do set result=%%~fi set current= for /f "usebackq tokens=2 delims=[]" %%i in (`dir /a:l "%~dp1" 2^>nul ^ - ^| find "> %~n1 ["`) do ( + ^| find "> %~n1 [" 2^>nul`) do ( set current=%%i ) if not "%current%"=="" call :follow_links "%current%", result diff --git a/sdk/bin/dartanalyzer.bat b/sdk/bin/dartanalyzer.bat index 4e8ba547df8..464aaee5402 100644 --- a/sdk/bin/dartanalyzer.bat +++ b/sdk/bin/dartanalyzer.bat @@ -60,7 +60,7 @@ setlocal for %%i in (%1) do set result=%%~fi set current= for /f "usebackq tokens=2 delims=[]" %%i in (`dir /a:l "%~dp1" 2^>nul ^ - ^| %SystemRoot%\System32\find.exe "> %~n1 ["`) do ( + ^| %SystemRoot%\System32\find.exe "> %~n1 [" 2^>nul`) do ( set current=%%i ) if not "%current%"=="" call :follow_links "%current%", result diff --git a/sdk/bin/dartanalyzer_sdk.bat b/sdk/bin/dartanalyzer_sdk.bat index 5fe4ae5ac16..ab66885f7a4 100644 --- a/sdk/bin/dartanalyzer_sdk.bat +++ b/sdk/bin/dartanalyzer_sdk.bat @@ -42,7 +42,7 @@ setlocal for %%i in (%1) do set result=%%~fi set current= for /f "usebackq tokens=2 delims=[]" %%i in (`dir /a:l "%~dp1" 2^>nul ^ - ^| find "> %~n1 ["`) do ( + ^| find "> %~n1 [" 2^>nul`) do ( set current=%%i ) if not "%current%"=="" call :follow_links "%current%", result diff --git a/sdk/bin/dartdevc.bat b/sdk/bin/dartdevc.bat index dd49b4337fe..fec39e46448 100644 --- a/sdk/bin/dartdevc.bat +++ b/sdk/bin/dartdevc.bat @@ -56,7 +56,7 @@ setlocal for %%i in (%1) do set result=%%~fi set current= for /f "usebackq tokens=2 delims=[]" %%i in (`dir /a:l "%~dp1" 2^>nul ^ - ^| find "> %~n1 ["`) do ( + ^| find "> %~n1 [" 2^>nul`) do ( set current=%%i ) if not "%current%"=="" call :follow_links "%current%", result diff --git a/sdk/bin/dartdoc.bat b/sdk/bin/dartdoc.bat index b519129e3f5..37ed5f836ca 100644 --- a/sdk/bin/dartdoc.bat +++ b/sdk/bin/dartdoc.bat @@ -34,7 +34,7 @@ setlocal for %%i in (%1) do set result=%%~fi set current= for /f "usebackq tokens=2 delims=[]" %%i in (`dir /a:l "%~dp1" 2^>nul ^ - ^| %SystemRoot%\System32\find.exe "> %~n1 ["`) do ( + ^| %SystemRoot%\System32\find.exe "> %~n1 [" 2^>nul`) do ( set current=%%i ) if not "%current%"=="" call :follow_links "%current%", result diff --git a/sdk/bin/dartfmt.bat b/sdk/bin/dartfmt.bat index cd5930214bc..7a7412bbbb4 100644 --- a/sdk/bin/dartfmt.bat +++ b/sdk/bin/dartfmt.bat @@ -47,7 +47,7 @@ setlocal for %%i in (%1) do set result=%%~fi set current= for /f "usebackq tokens=2 delims=[]" %%i in (`dir /a:l "%~dp1" 2^>nul ^ - ^| %SystemRoot%\System32\find.exe "> %~n1 ["`) do ( + ^| %SystemRoot%\System32\find.exe "> %~n1 [" 2^>nul`) do ( set current=%%i ) if not "%current%"=="" call :follow_links "%current%", result diff --git a/sdk/bin/pub.bat b/sdk/bin/pub.bat index 2ad2baacbe3..7eb8b0dde42 100644 --- a/sdk/bin/pub.bat +++ b/sdk/bin/pub.bat @@ -46,7 +46,7 @@ setlocal for %%i in (%1) do set result=%%~fi set current= for /f "usebackq tokens=2 delims=[]" %%i in (`dir /a:l "%~dp1" 2^>nul ^ - ^| %SystemRoot%\System32\find.exe "> %~n1 ["`) do ( + ^| %SystemRoot%\System32\find.exe "> %~n1 [" 2^>nul`) do ( set current=%%i ) if not "%current%"=="" call :follow_links "%current%", result diff --git a/sdk/bin/pub_sdk.bat b/sdk/bin/pub_sdk.bat index 0f0024d7f84..3ea8f1331f8 100644 --- a/sdk/bin/pub_sdk.bat +++ b/sdk/bin/pub_sdk.bat @@ -35,7 +35,7 @@ setlocal for %%i in (%1) do set result=%%~fi set current= for /f "usebackq tokens=2 delims=[]" %%i in (`dir /a:l "%~dp1" 2^>nul ^ - ^| find "> %~n1 ["`) do ( + ^| find "> %~n1 [" 2^>nul`) do ( set current=%%i ) if not "%current%"=="" call :follow_links "%current%", result