[DDS] Start running tests that are currently getting skipped

The test runner only runs files that end with "_test.dart". This is
evidenced by
https://dart-current-results.web.app/#/filter=pkg/dds/test&showAll
not showing any results for the tests renamed in this CL.

The tests renamed in this CL were found by runnning
`find pkg/dds/test | sed "/.*_test[.]dart/d"`

Some changes had to be made to
pkg/dds/test/client_resume_approvals_no_longer_require_permission_test.dart
after renaming it, the other tests did not have to be changed after
getting renamed.

Change-Id: Ib3b30ba784b182e4cc014d93aa5d8a792f8bb457
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367700
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
This commit is contained in:
Derek Xu 2024-05-29 19:56:57 +00:00 committed by Commit Queue
parent f72f43096c
commit b53b6b7f0b
6 changed files with 14 additions and 8 deletions

View file

@ -49,7 +49,7 @@ final test = <IsolateTest>[
void main([args = const <String>[]]) => runIsolateTests(
args,
test,
'client_resume_approvals_force_resume.dart',
'client_resume_approvals_force_resume_test.dart',
testeeConcurrent: fooBar,
pauseOnStart: true,
pauseOnExit: true,

View file

@ -33,16 +33,22 @@ final test = <IsolateTest>[
await hasPausedAtStart(service, isolateRef);
// When one client resumes, DDS waits to resume until the other client
// indicates it's ready.
// When one client indicates that it's ready to resume, DDS waits to resume
// until the other client indicates it's ready.
await client2.readyToResume(isolateId);
await hasPausedAtStart(service, isolateRef);
// If the only remaining client changes their resume permissions, DDS
// should check if the isolate should be resumed. In this case, the only
// other client requiring permission to resume has indicated it's ready
// so the isolate is resumed and pauses at exit.
// other client requiring permission to resume has indicated that it's
// ready, so the isolate is resumed and pauses at exit.
// [requireUserPermissionToResume] must be called in addition to
// [requirePermissionToResume], because the testee is started with
// --pause-isolates-on-start, which makes DDS's
// [IsolateManager._determineRequireUserPermissionToResumeFromFlags] require
// clients to have user permission to resume.
await client1.requirePermissionToResume(onPauseStart: false);
await client1.requireUserPermissionToResume(onPauseStart: false);
await hasStoppedAtExit(service, isolateRef);
},
];
@ -50,7 +56,7 @@ final test = <IsolateTest>[
void main([args = const <String>[]]) => runIsolateTests(
args,
test,
'client_resume_approvals_no_longer_require_permission.dart',
'client_resume_approvals_no_longer_require_permission_test.dart',
testeeConcurrent: fooBar,
pauseOnStart: true,
pauseOnExit: true,

View file

@ -58,7 +58,7 @@ final test = <IsolateTest>[
void main([args = const <String>[]]) => runIsolateTests(
args,
test,
'client_resume_approvals_no_longer_require_user_permission.dart',
'client_resume_approvals_no_longer_require_user_permission_test.dart',
testeeConcurrent: fooBar,
pauseOnStart: true,
pauseOnExit: true,

View file

@ -69,7 +69,7 @@ final test = <IsolateTest>[
void main([args = const <String>[]]) => runIsolateTests(
args,
test,
'client_resume_approvals_require_user_permission.dart',
'client_resume_approvals_require_user_permission_test.dart',
testeeConcurrent: fooBar,
pauseOnStart: true,
pauseOnExit: true,