[VM/Service] Rename JSONStream::AppendSerializedObject to JSONStream::AppendBytes

TEST=CI

Change-Id: I2bb950c608716156e0dfe357a0fd481463b8d0dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287800
Reviewed-by: Ben Konyi <bkonyi@google.com>
This commit is contained in:
Derek Xu 2023-04-17 15:58:28 +00:00 committed by Commit Queue
parent 4cd9c9c666
commit b4aa83b0b7
5 changed files with 14 additions and 14 deletions

View file

@ -54,6 +54,7 @@ void BaseTextBuffer::AddChar(char ch) {
}
void BaseTextBuffer::AddRaw(const uint8_t* buffer, intptr_t buffer_length) {
ASSERT(buffer != nullptr);
if (!EnsureCapacity(buffer_length)) {
buffer_length = capacity_ - length_ - 1; // Copy what fits.
}

View file

@ -156,16 +156,16 @@ class JSONStream : ValueObject {
intptr_t* offset,
intptr_t* count);
// Append |buffer| to the stream.
void AppendBytes(const uint8_t* buffer, intptr_t buffer_length) {
writer_.AppendBytes(buffer, buffer_length);
}
// Append |serialized_object| to the stream.
void AppendSerializedObject(const char* serialized_object) {
writer_.AppendSerializedObject(serialized_object);
}
// Append |buffer| to the stream.
void AppendSerializedObject(const uint8_t* buffer, intptr_t buffer_length) {
writer_.AppendSerializedObject(buffer, buffer_length);
}
// Append |serialized_object| to the stream with |property_name|.
void AppendSerializedObject(const char* property_name,
const char* serialized_object) {

View file

@ -35,16 +35,15 @@ class MaybeOnStackBuffer {
JSONWriter::JSONWriter(intptr_t buf_size)
: open_objects_(0), buffer_(buf_size) {}
void JSONWriter::AppendBytes(const uint8_t* buffer, intptr_t buffer_length) {
buffer_.AddRaw(buffer, buffer_length);
}
void JSONWriter::AppendSerializedObject(const char* serialized_object) {
PrintCommaIfNeeded();
buffer_.AddString(serialized_object);
}
void JSONWriter::AppendSerializedObject(const uint8_t* buffer,
intptr_t buffer_length) {
buffer_.AddRaw(buffer, buffer_length);
}
void JSONWriter::AppendSerializedObject(const char* property_name,
const char* serialized_object) {
PrintCommaIfNeeded();

View file

@ -23,12 +23,12 @@ class JSONWriter : ValueObject {
void PrintCommaIfNeeded();
// Append |buffer| to the stream.
void AppendBytes(const uint8_t* buffer, intptr_t buffer_length);
// Append |serialized_object| to the stream.
void AppendSerializedObject(const char* serialized_object);
// Append |buffer| to the stream.
void AppendSerializedObject(const uint8_t* buffer, intptr_t buffer_length);
// Append |serialized_object| to the stream with |property_name|.
void AppendSerializedObject(const char* property_name,
const char* serialized_object);

View file

@ -49,7 +49,7 @@ static int TestUtilities(const uint8_t* Data, size_t Size) {
// Json writer.
dart::JSONWriter writer(1);
writer.OpenObject("object");
writer.AppendSerializedObject(Data, Size);
writer.AppendBytes(Data, Size);
writer.CloseObject();
for (size_t i = 0; i < Size; i++) {
writer.PrintValue(static_cast<intptr_t>(Data[i]));