languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 13:08:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

dart2js cps: Fix bug in trampoline visitor.

Browse source 
If a continuation was visited directly (as the root of the
trampoline) the actions pushed in traverseContinuation would
not get processed.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/1427643009 .
This commit is contained in:
Asger Feldthaus 2015-11-05 13:14:55 +01:00
parent b13607d247
commit b466453025
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart
View file

@ -2067,7 +2067,9 @@ class TrampolineRecursiveVisitor extends DeepRecursiveVisitor {
if (cont.isReturnContinuation) {
traverseContinuation(cont);
} else {
_trampoline(traverseContinuation(cont));
int initialHeight = _stack.length;
Expression body = traverseContinuation(cont);
_trampoline(body, initialHeight: initialHeight);
}
}
@ -2107,8 +2109,8 @@ class TrampolineRecursiveVisitor extends DeepRecursiveVisitor {
return node.body;
}
void _trampoline(Expression node) {
int initialHeight = _stack.length;
void _trampoline(Expression node, {int initialHeight}) {
initialHeight = initialHeight ?? _stack.length;
_processBlock(node);
while (_stack.length > initialHeight) {
StackAction callback = _stack.removeLast();