From b3c0b58e93834d63e6205f103c86abf6ef4230f9 Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Fri, 23 Apr 2021 12:08:02 +0000 Subject: [PATCH] Revert "linter 1.4.0" This reverts commit 17644eea3905ca97ff4a22d1ac6f1ecfea549b66. Reason for revert: This caused various failures in HHH configuration which is an early warning that dart-lang/sdk -> flutter/{engine,flutter} rolls will not work smoothly. See more information in go/dartvm-gardening-log for various failures this causes. Original change's description: > linter 1.4.0 > > Mitigating PRs: > > https://dart-review.googlesource.com/c/sdk/+/196223 > https://dart-review.googlesource.com/c/sdk/+/196180 > > https://github.com/flutter/flutter/pull/80817 > https://github.com/flutter/flutter/pull/80901 > > > > > > Change-Id: Ib916d541076e24b9e8db1d6120dbc043d9e40b87 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196026 > Commit-Queue: Phil Quitslund > Reviewed-by: Brian Wilkerson TBR=brianwilkerson@google.com,pquitslund@google.com,davidmorgan@google.com Change-Id: I15af9de53d98de7b65902a015bef7ac2d368abeb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196499 Reviewed-by: Martin Kustermann Commit-Queue: Martin Kustermann --- CHANGELOG.md | 8 +------- DEPS | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7bf5a3a5e08..dbc15dc0b66 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,14 +27,8 @@ #### Linter -Updated the Linter to `1.4.0`, which includes: +Updated the Linter to `1.3.0`, which includes: -- `directives_ordering` now checks ordering of `package:` imports in code - outside pub packages. -- simple reachability analysis added to `use_build_context_synchronously` to - short-circuit await-discovery in terminating blocks. -- `use_build_context_synchronously` updated to recognize nullable types when - accessed from legacy libraries. - updated `non_constant_identifier_names` to check local variables, for-loop initializers and catch clauses. - updated error range of `lines_longer_than_80_chars` to start at 80 to make diff --git a/DEPS b/DEPS index 146ab902da5..dab41b050f9 100644 --- a/DEPS +++ b/DEPS @@ -124,7 +124,7 @@ vars = { "intl_tag": "0.17.0-nullsafety", "jinja2_rev": "2222b31554f03e62600cd7e383376a7c187967a1", "json_rpc_2_rev": "b8dfe403fd8528fd14399dee3a6527b55802dd4d", - "linter_tag": "1.4.0", + "linter_tag": "1.3.0", "logging_rev": "e2f633b543ef89c54688554b15ca3d7e425b86a2", "markupsafe_rev": "8f45f5cfa0009d2a70589bcda0349b8cb2b72783", "markdown_rev": "9c4beaac96d8f008078e00b027915f81b665d2de",