languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-06 00:59:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

dart2js Uri patch: avoid unnecessary code-unit to String conversions

Browse source 
results in:

H.Primitives_stringFromCharCode(C.JSString_methods.codeUnitAt$1("0123456789ABCDEF", $byte & 15)
-->
"0123456789ABCDEF"[$byte & 15]

dart2js does not know how to do this yet.

R=lrn@google.com

Review URL: https://codereview.chromium.org/1420303011 .
This commit is contained in:
Stephen Adams 2015-11-05 17:55:41 -08:00
parent 42b9d7b702
commit b3a4cc337c
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sdk/lib/_internal/js_runtime/lib/core_patch.dart
View file

@ -558,12 +558,12 @@ class Uri {
((canonicalTable[byte >> 4] & (1 << (byte & 0x0f))) != 0)) {
result.writeCharCode(byte);
} else if (spaceToPlus && byte == _SPACE) {
result.writeCharCode(_PLUS);
result.write('+');
} else {
const String hexDigits = '0123456789ABCDEF';
result.writeCharCode(_PERCENT);
result.writeCharCode(hexDigits.codeUnitAt(byte >> 4));
result.writeCharCode(hexDigits.codeUnitAt(byte & 0x0f));
result.write('%');
result.write(hexDigits[(byte >> 4) & 0x0f]);
result.write(hexDigits[byte & 0x0f]);
}
}
return result.toString();