languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix update_static_error_tests.dart after recent binary removals.

Browse source 
We no longer build separate binaries for `dartanalyzer` and `dart2js`,
so we need to do something different.

For `dartanalyzer`, we just run the `dartanalyzer` script directly
(because the features we need for testing aren't available directly
from `dart analyze`).  For `dart2js`, we run in the new way (`dart
compile js`).

Change-Id: I7e34052a9e6ad62596279ca32604e32291a45953
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251842
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
This commit is contained in:
Paul Berry 2022-07-19 16:35:54 +00:00 committed by Commit Bot
parent b74f0845d6
commit b326d00e96
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
pkg/test_runner/tool/update_static_error_tests.dart
View file

@ -21,8 +21,7 @@ const _usage =
"Usage: dart update_static_error_tests.dart [flags...] <path glob>";
final _dartPath = _findBinary("dart", "exe");
final _analyzerPath = _findBinary("dartanalyzer", "bat");
final _dart2jsPath = _findBinary("dart2js", "bat");
final _analyzerPath = p.join('pkg', 'analyzer_cli', 'bin', 'analyzer.dart');
Future<void> main(List<String> args) async {
var sources = ErrorSource.all.map((e) => e.marker).toList();
@ -210,7 +209,8 @@ Future<List<StaticError>> runAnalyzer(File file, List<String> options) async {
// TODO(rnystrom): Running the analyzer command line each time is very slow.
// Either import the analyzer as a library, or at least invoke it in a batch
// mode.
var result = await Process.run(_analyzerPath, [
var result = await Process.run(_dartPath, [
_analyzerPath,
...options,
"--format=json",
file.absolute.path,
@ -265,7 +265,9 @@ Future<List<StaticError>> runCfe(File file, List<String> options) async {
/// Invoke dart2js on [file] and gather all static errors it reports.
Future<List<StaticError>> runDart2js(
File file, List<String> options, List<StaticError> cfeErrors) async {
var result = await Process.run(_dart2jsPath, [
var result = await Process.run(_dartPath, [
'compile',
'js',
...options,
"-o",
"dev:null", // Output is only created for file URIs.