languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 22:01:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

[infra] Fix approve_results deleting existing meta-information.

Browse source 
Change-Id: I585344cdf13d8cde93b0eba8e850d436a11c9200
Reviewed-on: https://dart-review.googlesource.com/c/91200
Reviewed-by: William Hesse <whesse@google.com>
This commit is contained in:
Jonas Termansen 2019-01-25 14:38:48 +00:00
parent 4f9af4cd03
commit b2a93177a0
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tools/approve_results.dart
View file

@ -684,12 +684,14 @@ ${parser.usage}""");
final futures = <Future>[];
for (final String bot in unapprovedBots) {
Map<String, dynamic> approveData(Test test) {
final data = new Map<String, dynamic>.from(test.resultData);
if (!test.isApproved) {
if (test.isApproved) {
return test.approvedResultData;
} else {
final data = new Map<String, dynamic>.from(test.resultData);
data["approver"] = username;
data["approved_at"] = now;
return data;
}
return data;
}
final dataList = testsForBots[bot].map(approveData).toList();