languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 09:58:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable strong mode when previewDart2 is enabled

Browse source 
Change-Id: I2d26dec1e3e4dc7a32ef51ff740211032919adb1
Reviewed-on: https://dart-review.googlesource.com/28524
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Brian Wilkerson 2017-12-12 14:08:40 +00:00 committed by commit-bot@chromium.org
parent c284c428bb
commit b1fce8078e
2 changed files with 6 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
pkg/analyzer/test/generated/non_hint_code_kernel_test.dart
View file

@ -31,13 +31,6 @@ class NonHintCodeTest_Kernel extends NonHintCodeTest_Driver {
await super.test_deadCode_deadBlock_if_debugConst_propertyAccessor();
}
@failingTest
@override
@potentialAnalyzerProblem
test_deadCode_statementAfterIfWithoutElse() async {
await super.test_deadCode_statementAfterIfWithoutElse();
}
@failingTest
@override
@potentialAnalyzerProblem
@ -45,27 +38,6 @@ class NonHintCodeTest_Kernel extends NonHintCodeTest_Driver {
await super.test_deprecatedMemberUse_inDeprecatedLibrary();
}
@failingTest
@override
@potentialAnalyzerProblem
test_divisionOptimization() async {
// NoSuchMethodError: The getter 'element' was called on null.
// Receiver: null
// Tried calling: element
// #0 Object.noSuchMethod (dart:core-patch/dart:core/object_patch.dart:46)
// #1 ResolutionApplier.visitMethodInvocation (package:analyzer/src/fasta/resolution_applier.dart:385:48)
// #2 MethodInvocationImpl.accept (package:analyzer/src/dart/ast/ast.dart:7595:49)
// #3 ResolutionApplier.visitBinaryExpression (package:analyzer/src/fasta/resolution_applier.dart:115:23)
await super.test_divisionOptimization();
}
@failingTest
@override
@potentialAnalyzerProblem
test_divisionOptimization_supressIfDivisionOverridden() async {
await super.test_divisionOptimization_supressIfDivisionOverridden();
}
@failingTest
@override
@potentialAnalyzerProblem
@ -84,8 +56,9 @@ class NonHintCodeTest_Kernel extends NonHintCodeTest_Driver {
@failingTest
@override
@potentialAnalyzerProblem
test_unnecessaryCast_conditionalExpression() async {
await super.test_unnecessaryCast_conditionalExpression();
test_unnecessaryCast_generics() async {
// Expected 0 errors of type HintCode.UNNECESSARY_CAST, found 1 (90)
await super.test_unnecessaryCast_generics();
}
@failingTest

4
pkg/analyzer/test/generated/resolver_test_case.dart
View file

@ -667,7 +667,9 @@ class ResolverTestCase extends EngineTestCase {
options ??= defaultAnalysisOptions;
if (enableNewAnalysisDriver) {
if (previewDart2) {
(options as AnalysisOptionsImpl).useFastaParser = true;
(options as AnalysisOptionsImpl)
..strongMode = true
..useFastaParser = true;
}
DartSdk sdk = new MockSdk(resourceProvider: resourceProvider)
..context.analysisOptions = options;