mirror of
https://github.com/dart-lang/sdk
synced 2024-10-03 00:45:16 +00:00
[gardening] Build analyze_snapshot/gen_snapshot in both host & target toolchain
This should make vm/dart_2/analyze_snapshot_binary_test pass on dartkp-linux-release-arm64 & dartk-linux-release-arm64 by ensuring arm64 `gen_snapshot` & `analyze_snapshot` binaries are available on the device when running tests on arm64 HW. Change-Id: Icd814ff6df22a33b651733e4c3dc99873cf56a58 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279970 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
This commit is contained in:
parent
0a78aac714
commit
b15da0b0e9
9
BUILD.gn
9
BUILD.gn
|
@ -64,7 +64,14 @@ group("runtime") {
|
|||
# The analyze_snapshot tool is only supported on 64 bit AOT builds running
|
||||
# under linux and android platforms
|
||||
if (build_analyze_snapshot) {
|
||||
deps += [ "runtime/bin:analyze_snapshot($host_toolchain)" ]
|
||||
deps += [
|
||||
# The `analyze_snapshot` tests require the `analyze_snapshot` as well as
|
||||
# `gen_snapshot` binaries.
|
||||
"runtime/bin:analyze_snapshot",
|
||||
"runtime/bin:analyze_snapshot($host_toolchain)",
|
||||
"runtime/bin:gen_snapshot",
|
||||
"runtime/bin:gen_snapshot($host_toolchain)",
|
||||
]
|
||||
}
|
||||
|
||||
if (is_linux || is_android) {
|
||||
|
|
|
@ -510,6 +510,6 @@ dart_2/entrypoints/*: SkipByDesign # These tests are for compiler optimizations
|
|||
|
||||
# The analyze_snapshot tool tests are only supported on 64 bit AOT builds running under
|
||||
# release or product runtimes for linux and android platforms
|
||||
[ $arch != arm64 && $arch != arm64c && $arch != simarm64 && $arch != simarm64c && $arch != x64 || $compiler != dartk && $compiler != dartkp || $mode != product && $mode != release || $runtime != dart_precompiled && $runtime != vm || $system != android && $system != linux ]
|
||||
[ $arch != arm64 && $arch != arm64c && $arch != simarm64 && $arch != simarm64c && $arch != x64 && $arch != x64c || $compiler != dartk && $compiler != dartkp || $mode != product && $mode != release || $runtime != dart_precompiled && $runtime != vm || $system != android && $system != linux ]
|
||||
dart/analyze_snapshot_binary_test: SkipByDesign # Only run on 64bit AOT on standard architectures
|
||||
dart_2/analyze_snapshot_binary_test: SkipByDesign # Only run on 64bit AOT on standard architectures
|
||||
|
|
Loading…
Reference in a new issue