Update golden files.

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2933763002 .

pkg/front_end/test/fasta/compile.status

@@ -12,9 +12,7 @@ DeltaBlue: Fail # Missing types on constructor parameters.
 async_function: Fail # Async transformer should be optional.
 await: Fail
 call: Fail # Test can't run.
-covariant_generic: Fail # Missing types on constructor parameters.
 cycles: Fail # Compile-time error handling destroys program.
-external: Fail # External method marked abstract.
 fallthrough: Fail # Missing FallThroughError.
 function_type_recovery: Fail
 invocations: Fail
@@ -345,7 +343,6 @@ rasta/super_initializer: Fail
 rasta/super_mixin: Fail
 rasta/super_operator: Fail
 rasta/supports_reflection: VerificationError
-rasta/switch_fall_through: Fail
 rasta/try_label: Fail
 rasta/type_literals: Fail
 rasta/type_with_parse_error: Fail

pkg/front_end/test/fasta/outline.status

@@ -2,8 +2,6 @@
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE.md file.
 
-rasta/class_hierarchy: Fail # Fixed in ahe's dev branch.
-
 inference/async_closure_return_type_flatten: Fail
 inference/async_closure_return_type_future: Fail
 inference/async_closure_return_type_future_or: Fail
@@ -273,10 +271,10 @@ inference/unsafe_block_closure_inference_method_call_implicit_type_param: Fail
 inference/unsafe_block_closure_inference_method_call_no_type_param: Fail
 inference/void_return_type_subtypes_dynamic: Fail
 
-rasta/generic_factory: Fail
 rasta/issue_000032: Fail
 rasta/issue_000045: Fail
 rasta/issue_000046: Fail
 rasta/issue_000047: Fail
+rasta/native_is_illegal: Pass # Issue 29763
 rasta/super_mixin: Fail
 rasta/type_with_parse_error: Fail

pkg/front_end/testcases/covariant_generic.dart.direct.expect

@@ -2,6 +2,7 @@ library;
 import self as self;
 import "dart:core" as core;
 
+typedef Callback = <T extends core::Object>(T) → void;
 class Foo<T extends core::Object> extends core::Object {
   final field self::Foo::T finalField;
   final field (self::Foo::T) → void callbackField;

pkg/front_end/testcases/external.dart.direct.expect

@@ -3,14 +3,14 @@ import self as self;
 import "dart:core" as core;
 import "dart:isolate" as iso;
 
-static field dynamic subscription = null;
+static field dynamic subscription;
 static method onData(dynamic x) → void {
   core::print(x);
   self::subscription.cancel();
 }
 static method main() → dynamic {
   dynamic string = core::String::fromCharCode(65);
-  dynamic port = iso::ReceivePort::•();
+  dynamic port = new iso::_ReceivePortImpl::•();
   self::subscription = port.listen(self::onData);
   port.sendPort.send(string);
 }

pkg/front_end/testcases/invocations.dart.direct.expect

@@ -4,9 +4,9 @@ import "dart:core" as core;
 
 static method main() → dynamic {
   core::print("Hello, World!");
-  throw new core::NoSuchMethodError::•(null, #z, <dynamic>["Hello, World!"], <dynamic, dynamic>{}, null);
-  (throw new core::NoSuchMethodError::•(null, #z, <dynamic>[], <dynamic, dynamic>{}, null)).print("Hello, World!");
-  (throw new core::NoSuchMethodError::•(null, #y, <dynamic>[], <dynamic, dynamic>{}, null)).z.print("Hello, World!");
-  (throw new core::NoSuchMethodError::•(null, #x, <dynamic>[], <dynamic, dynamic>{}, null)).y.z.print("Hello, World!");
-  1.+(core::print("Hello, World!")).+(throw new core::NoSuchMethodError::•(null, #z, <dynamic>["Hello, World!"], <dynamic, dynamic>{}, null)).+((throw new core::NoSuchMethodError::•(null, #z, <dynamic>[], <dynamic, dynamic>{}, null)).print("Hello, World!")).+((throw new core::NoSuchMethodError::•(null, #y, <dynamic>[], <dynamic, dynamic>{}, null)).z.print("Hello, World!")).+((throw new core::NoSuchMethodError::•(null, #x, <dynamic>[], <dynamic, dynamic>{}, null)).y.z.print("Hello, World!"));
+  throw new core::NoSuchMethodError::_withType(null, #z, 32, <dynamic>["Hello, World!"].toList(growable: false), <dynamic, dynamic>{}, null);
+  throw new core::NoSuchMethodError::_withType(null, #z, 33, <dynamic>[].toList(growable: false), <dynamic, dynamic>{}, null);
+  throw new core::NoSuchMethodError::_withType(null, #y, 33, <dynamic>[].toList(growable: false), <dynamic, dynamic>{}, null);
+  throw new core::NoSuchMethodError::_withType(null, #x, 33, <dynamic>[].toList(growable: false), <dynamic, dynamic>{}, null);
+  1.+(core::print("Hello, World!")).+(throw new core::NoSuchMethodError::_withType(null, #z, 32, <dynamic>["Hello, World!"].toList(growable: false), <dynamic, dynamic>{}, null)).+(throw new core::NoSuchMethodError::_withType(null, #z, 33, <dynamic>[].toList(growable: false), <dynamic, dynamic>{}, null)).+(throw new core::NoSuchMethodError::_withType(null, #y, 33, <dynamic>[].toList(growable: false), <dynamic, dynamic>{}, null)).+(throw new core::NoSuchMethodError::_withType(null, #x, 33, <dynamic>[].toList(growable: false), <dynamic, dynamic>{}, null));
 }

pkg/front_end/testcases/rasta/class_hierarchy.dart.outline.expect

@@ -18,7 +18,7 @@ class C extends core::Object {
 class D extends core::Object {
   static field dynamic _redirecting# = <dynamic>[self::D::•];
   static factory •() → self::D
-    throw new core::NoSuchMethodError::_withType(null, #Missing, -1, <dynamic>[].toList(growable: false), <dynamic, dynamic>{}, null);
+    let dynamic #redirecting_factory = "Missing" in invalid-expression;
 }
 static method main() → void
   ;

pkg/front_end/testcases/rasta/duplicated_mixin.dart.direct.expect

@@ -8,11 +8,6 @@ class Mixin extends core::Object {
     : super core::Object::•()
     ;
 }
-class A extends self::Object&Mixin&Mixin {
-  constructor •() → void
-    : super self::Object&Mixin&Mixin::•()
-    ;
-}
 abstract class Object&Mixin extends core::Object implements self::Mixin {
   field dynamic field = null;
   constructor •() → void
@@ -25,3 +20,8 @@ abstract class Object&Mixin&Mixin extends self::Object&Mixin implements self::Mi
     : super self::Object&Mixin::•()
     ;
 }
+class A extends self::Object&Mixin&Mixin {
+  constructor •() → void
+    : super self::Object&Mixin&Mixin::•()
+    ;
+}

pkg/front_end/testcases/rasta/generic_factory.dart.direct.expect

@@ -23,11 +23,11 @@ class A<T extends core::Object> extends core::Object {
     : super core::Object::•()
     ;
   static factory a<T extends core::Object>() → self::A<self::A::a::T>
-    let final dynamic #t1 = self::B::a in invalid-expression;
+    let dynamic #redirecting_factory = self::B::a in invalid-expression;
   static factory b<T extends core::Object>() → self::A<self::A::b::T>
-    let final dynamic #t2 = self::B::a in invalid-expression;
+    let dynamic #redirecting_factory = self::B::a in invalid-expression;
   static factory c<T extends core::Object>() → self::A<self::A::c::T>
-    throw new core::NoSuchMethodError::_withType(null, #Missing, -1, <dynamic>[].toList(growable: false), <dynamic, dynamic>{}, null);
+    let dynamic #redirecting_factory = "Missing" in invalid-expression;
 }
 class B<S extends core::Object> extends self::A<self::B::S> {
   static field dynamic _redirecting# = <dynamic>[self::B::a, self::B::b];
@@ -35,9 +35,9 @@ class B<S extends core::Object> extends self::A<self::B::S> {
     : super self::A::internal()
     ;
   static factory a<S extends core::Object>() → self::B<self::B::a::S>
-    let final dynamic #t3 = self::C::• in invalid-expression;
+    let dynamic #redirecting_factory = self::C::• in invalid-expression;
   static factory b<S extends core::Object>() → self::B<self::B::b::S>
-    let final dynamic #t4 = self::C::• in invalid-expression;
+    let dynamic #redirecting_factory = self::C::• in invalid-expression;
 }
 class C<U extends core::Object> extends self::B<self::C::U> {
   constructor •() → void
@@ -49,5 +49,5 @@ static method main() → dynamic {
   new self::C::•<self::C3>();
   new self::C::•<self::C3>();
   new self::C::•<self::C3>();
-  self::A::c<self::C3>();
+  throw new core::NoSuchMethodError::_withType(null, #Missing, 32, <dynamic>[].toList(growable: false), <dynamic, dynamic>{}, null);
 }

pkg/front_end/testcases/rasta/generic_factory.dart.outline.expect

@@ -19,20 +19,20 @@ class A<T extends core::Object> extends core::Object {
   constructor internal() → void
     ;
   static factory a<T extends core::Object>() → self::A<self::A::a::T>
-    let final dynamic #t1 = self::B::a in invalid-expression;
+    let dynamic #redirecting_factory = self::B::a in invalid-expression;
   static factory b<T extends core::Object>() → self::A<self::A::b::T>
-    let final dynamic #t2 = self::B::a in invalid-expression;
+    let dynamic #redirecting_factory = self::B::a in invalid-expression;
   static factory c<T extends core::Object>() → self::A<self::A::c::T>
-    throw new core::NoSuchMethodError::_withType(null, #Missing, -1, <dynamic>[].toList(growable: false), <dynamic, dynamic>{}, null);
+    let dynamic #redirecting_factory = "Missing" in invalid-expression;
 }
 class B<S extends core::Object> extends self::A<self::B::S> {
   static field dynamic _redirecting# = <dynamic>[self::B::a, self::B::b];
   constructor internal() → void
     ;
   static factory a<S extends core::Object>() → self::B<self::B::a::S>
-    let final dynamic #t3 = self::C::• in invalid-expression;
+    let dynamic #redirecting_factory = self::C::• in invalid-expression;
   static factory b<S extends core::Object>() → self::B<self::B::b::S>
-    let final dynamic #t4 = self::C::• in invalid-expression;
+    let dynamic #redirecting_factory = self::C::• in invalid-expression;
 }
 class C<U extends core::Object> extends self::B<self::C::U> {
   constructor •() → void

pkg/front_end/testcases/rasta/mixin_library.dart.direct.expect

@@ -11,7 +11,7 @@ class Mixin<T extends core::Object> extends core::Object {
     : super core::Object::•()
     ;
   method foo() → dynamic
-    return this.{=core::Object::noSuchMethod}(new core::_InvocationMirror::•("foo", <dynamic>[1, 1].toList(growable: false), <dynamic>[this].toList(growable: false), true)).+(self::f());
+    return this.{=core::Object::noSuchMethod}(new core::_InvocationMirror::•("foo", <dynamic>[0, 1, 1].toList(growable: false), <dynamic>[this].toList(growable: false), true)).+(self::f());
   method g(self::Mixin::T a) → self::Mixin::T
     return null;
   method h() → dynamic

pkg/front_end/testcases/rasta/super_operator.dart.direct.expect

@@ -21,12 +21,12 @@ class B extends self::A {
   operator [](dynamic i) → dynamic
     return this.{=self::A::[]}(i);
   operator []=(dynamic i, dynamic val) → dynamic
-    return let final dynamic #t1 = let final dynamic #t2 = i in let final dynamic #t3 = i = #t2.+(1) in #t2 in let final dynamic #t4 = super.{self::A::[]}(#t1).+(val) in let final dynamic #t5 = super.{self::A::[]=}(#t1, #t4) in #t4;
+    return let final dynamic #t1 = let final dynamic #t2 = i in let final dynamic #t3 = i = #t2.+(1) in #t2 in let final dynamic #t4 = this.{=self::A::[]}(#t1).+(val) in let final dynamic #t5 = this.{=self::A::[]=}(#t1, #t4) in #t4;
 }
 class Autobianchi extends core::Object {
   constructor •() → void
     : super core::Object::•()
     ;
   method g() → dynamic
-    return this.{=core::Object::noSuchMethod}(new core::_InvocationMirror::•("[]", core::List::from<dynamic>(<dynamic>[2, 2], growable: false), core::List::from<dynamic>(<dynamic>[this, 0], growable: false), true));
+    return this.{=core::Object::noSuchMethod}(new core::_InvocationMirror::•("[]", <dynamic>[0, 2, 2].toList(growable: false), <dynamic>[this, 0].toList(growable: false), true));
 }

pkg/front_end/testcases/rasta/switch_fall_through.dart.direct.expect

@@ -13,6 +13,7 @@ static method main() → dynamic {
           break #L1;
           ;
         }
+        throw new core::FallThroughError::•();
       }
     #L3:
     case 2:
@@ -34,6 +35,7 @@ static method main() → dynamic {
         finally {
           break #L1;
         }
+        throw new core::FallThroughError::•();
       }
     #L5:
     case 4:
@@ -44,6 +46,7 @@ static method main() → dynamic {
         }
         finally {
         }
+        throw new core::FallThroughError::•();
       }
     #L6:
     case 5:

pkg/front_end/testcases/rasta/type_literals.dart.direct.expect

@@ -2,6 +2,7 @@ library;
 import self as self;
 import "dart:core" as core;
 
+typedef Func = () → void;
 class C<T extends core::Object> extends core::Object {
   constructor •() → void
     : super core::Object::•()

pkg/front_end/testcases/rasta/typedef.dart.direct.expect

@@ -2,6 +2,7 @@ library;
 import self as self;
 import "dart:core" as core;
 
+typedef Foo = () → void;
 static method main() → dynamic {
   core::print(() → void);
   let final dynamic #t1 = null in invalid-expression;

pkg/front_end/testcases/redirecting_factory.dart.direct.expect

@@ -3,9 +3,15 @@ import self as self;
 import "dart:core" as core;
 
 abstract class FooBase<Tf extends core::Object> extends core::Object {
+  static field dynamic _redirecting# = <dynamic>[self::FooBase::•];
   abstract get x() → core::int;
+  static factory •<Tf extends core::Object>(core::int x) → self::FooBase<self::FooBase::•::Tf>
+    let dynamic #redirecting_factory = self::Foo::• in invalid-expression;
 }
 abstract class Foo<T extends core::Object> extends core::Object implements self::FooBase<dynamic> {
+  static field dynamic _redirecting# = <dynamic>[self::Foo::•];
+  static factory •<T extends core::Object>(core::int x) → self::Foo<self::Foo::•::T>
+    let dynamic #redirecting_factory = self::Bar::• in invalid-expression;
 }
 class Bar<Sb extends core::Object, Tb extends core::Object> extends core::Object implements self::Foo<self::Bar::Tb> {
   field core::int x;
@@ -23,8 +29,14 @@ class Builder<X extends core::Object> extends core::Object {
   }
 }
 class SimpleCase<A extends core::Object, B extends core::Object> extends core::Object {
+  static field dynamic _redirecting# = <dynamic>[self::SimpleCase::•];
+  static factory •<A extends core::Object, B extends core::Object>() → self::SimpleCase<self::SimpleCase::•::A, self::SimpleCase::•::B>
+    let dynamic #redirecting_factory = self::SimpleCaseImpl::• in invalid-expression;
 }
 class SimpleCaseImpl<Ai extends core::Object, Bi extends core::Object> extends core::Object implements self::SimpleCase<self::SimpleCaseImpl::Ai, self::SimpleCaseImpl::Bi> {
+  static field dynamic _redirecting# = <dynamic>[self::SimpleCaseImpl::•];
+  static factory •<Ai extends core::Object, Bi extends core::Object>() → self::SimpleCaseImpl<self::SimpleCaseImpl::•::Ai, self::SimpleCaseImpl::•::Bi>
+    let dynamic #redirecting_factory = self::SimpleCaseImpl2::• in invalid-expression;
 }
 class SimpleCaseImpl2<Ai2 extends core::Object, Bi2 extends core::Object> extends core::Object implements self::SimpleCaseImpl<self::SimpleCaseImpl2::Ai2, self::SimpleCaseImpl2::Bi2> {
   constructor •() → void