languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:39:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Re-land "[vm] Add type to _AsyncAwaitCompleter.start.""

Browse source 
This reverts commit 4049ab54e4.

Reason for revert: Appears to break standalone_2/dwarf_stack_trace_test and other related tests.

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8886276259895791440/+/steps/test_results/0/logs/new_test_failures__logs_/0

Original change's description:
> Re-land "[vm] Add type to _AsyncAwaitCompleter.start."
> 
> We need to relax vm/dart/causal_stacks/async_throws_stack_no_causal_test
> 
> Change-Id: I40c08d432afeac839ce4f49bbf48c3707b23ef7f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138804
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Commit-Queue: Samir Jindel <sjindel@google.com>

TBR=kustermann@google.com,sjindel@google.com,cskau@google.com

Change-Id: Ib77bdb5ba9927cf5a9a588570a5d70641e912aed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138791
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
This commit is contained in:
Ben Konyi 2020-03-09 22:16:39 +00:00 committed by commit-bot@chromium.org
parent 043af430c1
commit b01cb58320
3 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
runtime/tests/vm/dart/causal_stacks/utils.dart
View file

@ -616,16 +616,13 @@ Future<void> doTestsNoCausalNoLazy() async {
r'^#0 throwSync \(.*/utils.dart:16(:3)?\)$',
r'^#1 noYields3 \(.*/utils.dart:54(:3)?\)$',
r'^#2 _AsyncAwaitCompleter.start ',
// TODO: fix line number here
r'^#3 noYields3 \(.*/utils.dart(:53(:23)?|.*)\)$',
r'^#3 noYields3 \(.*/utils.dart:53(:23)?\)$',
r'^#4 noYields2 \(.*/utils.dart:50(:9)?\)$',
r'^#5 _AsyncAwaitCompleter.start ',
// TODO: fix line number here
r'^#6 noYields2 \(.*/utils.dart',
r'^#6 noYields2 \(.*/utils.dart:49(:23)?\)$',
r'^#7 noYields \(.*/utils.dart:46(:9)?\)$',
r'^#8 _AsyncAwaitCompleter.start ',
// TODO: fix line number here
r'^#9 noYields \(.*/utils.dart',
r'^#9 noYields \(.*/utils.dart:45(:22)?\)$',
];
await doTestAwait(
noYields,

2
sdk/lib/_internal/vm/lib/async_patch.dart
View file

@ -43,7 +43,7 @@ class _AsyncAwaitCompleter<T> implements Completer<T> {
}
}
void start(void Function() f) {
void start(f) {
f();
isSync = true;
}

2
sdk_nnbd/lib/_internal/vm/lib/async_patch.dart
View file

@ -41,7 +41,7 @@ class _AsyncAwaitCompleter<T> implements Completer<T> {
}
}
void start(void Function() f) {
void start(f) {
f();
isSync = true;
}