languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Ignore not ClassDeclaration target of an unknown method invocation.

Browse source 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1764743002 .
This commit is contained in:
Konstantin Shcheglov 2016-03-03 11:23:32 -08:00
parent 7c2c02d6a6
commit adcf43968f
2 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
pkg/analysis_server/lib/src/services/correction/fix_internal.dart
View file

@ -1990,13 +1990,17 @@ class FixProcessor {
}
ClassElement targetClassElement = targetType.element as ClassElement;
targetElement = targetClassElement;
// may be static
// prepare target ClassDeclaration
AstNode targetTypeNode = getParsedClassElementNode(targetClassElement);
if (targetTypeNode is! ClassDeclaration) {
return;
}
ClassDeclaration targetClassNode = targetTypeNode;
// maybe static
if (target is Identifier) {
staticModifier = target.bestElement.kind == ElementKind.CLASS;
}
// prepare insert offset
ClassDeclaration targetClassNode =
getParsedClassElementNode(targetClassElement);
prefix = ' ';
insertOffset = targetClassNode.end - 1;
if (targetClassNode.members.isEmpty) {

10
pkg/analysis_server/test/services/correction/fix_test.dart
View file

@ -4341,6 +4341,16 @@ main() {
await assertNoFix(DartFixKind.CREATE_METHOD);
}
test_undefinedMethod_create_BAD_targetIsEnum() async {
resolveTestUnit('''
enum MyEnum {A, B}
main() {
MyEnum.foo();
}
''');
await assertNoFix(DartFixKind.CREATE_METHOD);
}
test_undefinedMethod_create_generic_BAD_argumentType() async {
resolveTestUnit('''
class A<T> {