languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[deps] remove the package:pedantic dep

Browse source 
Change-Id: Icacaa97ccd1b1919a97c50bec431c54137c08b07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241984
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This commit is contained in:
Devon Carew 2022-04-22 16:44:30 +00:00 committed by Commit Bot
parent 6d88de709c
commit aa63ef8f4f
4 changed files with 8 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
DEPS
View file

@ -133,7 +133,6 @@ vars = {
"oauth2_rev": "7cd3284049fe5badbec9f2bea2afc41d14c01057",
"package_config_rev": "8731bf10b5375542792a32a0f7c8a6f370583d96",
"path_rev": "baedce9d2ca11ea2cdf54395a74eb038087777a4",
"pedantic_rev": "66f2f6c27581c7936482e83be80b27be2719901c",
"platform_rev": "1ffad63428bbd1b3ecaa15926bacfb724023648c",
"ply_rev": "604b32590ffad5cbb82e4afef1d305512d06ae93",
"pool_rev": "7abe634002a1ba8a0928eded086062f1307ccfae",
@ -380,8 +379,6 @@ deps = {
"@" + Var("package_config_rev"),
Var("dart_root") + "/third_party/pkg/path":
Var("dart_git") + "path.git" + "@" + Var("path_rev"),
Var("dart_root") + "/third_party/pkg/pedantic":
Var("dart_git") + "pedantic.git" + "@" + Var("pedantic_rev"),
Var("dart_root") + "/third_party/pkg/platform":
Var("dart_git") + "platform.dart.git" + "@" + Var("platform_rev"),
Var("dart_root") + "/third_party/pkg/pool":

6
pkg/dartdev/test/core_test.dart
View file

@ -105,7 +105,7 @@ void _packageConfig() {
test('hasDependency', () {
PackageConfig packageConfig = PackageConfig(jsonDecode(_packageData));
expect(packageConfig.hasDependency('test'), isFalse);
expect(packageConfig.hasDependency('pedantic'), isTrue);
expect(packageConfig.hasDependency('lints'), isTrue);
});
}
@ -149,8 +149,8 @@ const String _packageData = '''{
"configVersion": 2,
"packages": [
{
"name": "pedantic",
"rootUri": "file:///Users/.../.pub-cache/hosted/pub.dartlang.org/pedantic-1.9.0",
"name": "lints",
"rootUri": "file:///Users/.../.pub-cache/hosted/pub.dartlang.org/lints-1.0.1",
"packageUri": "lib/",
"languageVersion": "2.1"
},

4
pkg/dartdev/test/utils_test.dart
View file

@ -163,8 +163,8 @@ const String _packageData = '''{
"configVersion": 2,
"packages": [
{
"name": "pedantic",
"rootUri": "file:///Users/.../.pub-cache/hosted/pub.dartlang.org/pedantic-1.9.0",
"name": "lints",
"rootUri": "file:///Users/.../.pub-cache/hosted/pub.dartlang.org/lints-1.0.1",
"packageUri": "lib/",
"languageVersion": "2.1"
},

6
tools/package_deps/bin/package_deps.dart
View file

@ -233,9 +233,9 @@ class Package implements Comparable<Package> {
var extraDevDeclarations = Set<String>.from(_declaredDevDependencies)
..removeAll(devdeps);
// Remove package:pedantic and package:lints as they are often declared as
// dev dependencies in order to bring in their analysis_options.yaml files.
extraDevDeclarations.removeAll(['lints', 'pedantic']);
// Remove package:lints - it's often declared as a dev dependency in order
// to bring in analysis_options configuration files.
extraDevDeclarations.removeAll(['lints']);
if (extraDevDeclarations.isNotEmpty) {
out(' ${_printSet(extraDevDeclarations)} declared in '
"'dev_dependencies:' but not used in dev dirs.");