From a9ebb5c3c8afe3c7e250ca7775882baab74cd2d1 Mon Sep 17 00:00:00 2001 From: lambdabaa Date: Sat, 27 Jul 2019 20:57:59 +0000 Subject: [PATCH] Enable running language model unit tests on windows Change-Id: I63457934fcd23510f6a2848fbb00361ebb40a40f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110840 Reviewed-by: Brian Wilkerson Commit-Queue: Ari Aye --- DEPS | 2 +- .../services/completion/dart/language_model_test.dart | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/DEPS b/DEPS index 246cf0437be..e0c86c139a2 100644 --- a/DEPS +++ b/DEPS @@ -135,7 +135,7 @@ vars = { "term_glyph_tag": "1.0.1", "test_reflective_loader_tag": "0.1.8", "test_tag": "test-v1.6.4", - "tflite_native_rev": "712b8a93fbb4caf83ffed37f154da88c2a517a91", + "tflite_native_rev": "b32366dae7446e0e7c29f407cc74717f44b00b30", "typed_data_tag": "1.1.6", "unittest_rev": "2b8375bc98bb9dc81c539c91aaea6adce12e1072", "usage_tag": "3.4.0", diff --git a/pkg/analysis_server/test/services/completion/dart/language_model_test.dart b/pkg/analysis_server/test/services/completion/dart/language_model_test.dart index a436b60c685..32a09a8f74b 100644 --- a/pkg/analysis_server/test/services/completion/dart/language_model_test.dart +++ b/pkg/analysis_server/test/services/completion/dart/language_model_test.dart @@ -6,15 +6,16 @@ import 'dart:ffi'; import 'dart:io'; import 'package:analysis_server/src/services/completion/dart/language_model.dart'; +import 'package:path/path.dart' as path; import 'package:test/test.dart'; -final directory = - Platform.script.resolve('../../../../language_model/lexeme').path; +final directory = path.join(File.fromUri(Platform.script).parent.path, '..', + '..', '..', '..', 'language_model', 'lexeme'); const expectedLookback = 100; void main() { - if (Platform.isWindows || sizeOf() == 4) { - // We don't yet support running tflite on Windows or 32-bit systems. + if (sizeOf() == 4) { + // We don't yet support running tflite on 32-bit systems. return; }