languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-03 13:22:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

[frontend-server] Re-enable depfile test on Windows.

Browse source 
Split by ': ' and change test so it ignores difference in the path that gets escaped for ninja on Windows.

Bug: https://github.com/dart-lang/sdk/issues/33032
Change-Id: Iceeddba1a9c2d94a74c1f08d52144d2eb030f703
Reviewed-on: https://dart-review.googlesource.com/53681
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
This commit is contained in:
Alexander Aprelev 2018-05-04 15:21:08 +00:00 committed by commit-bot@chromium.org
parent 543d8775e3
commit a989bac685
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/vm/test/frontend_server_test.dart
View file

@ -7,6 +7,7 @@ import 'package:args/src/arg_results.dart';
import 'package:kernel/binary/ast_to_binary.dart';
import 'package:kernel/ast.dart' show Component;
import 'package:mockito/mockito.dart';
import 'package:path/path.dart' as path;
import 'package:test/test.dart';
import 'package:vm/incremental_compiler.dart';
@ -462,7 +463,7 @@ Future<int> main() async {
Directory tempDir;
setUp(() {
var systemTempDir = Directory.systemTemp;
tempDir = systemTempDir.createTempSync('foo');
tempDir = systemTempDir.createTempSync('foo bar');
});
tearDown(() {
@ -656,15 +657,11 @@ Future<int> main() async {
});
test('compile and produce deps file', () async {
if (Platform.isWindows) {
// TODO(dartbug.com/33032): Fix depfile generation on Windows.
return;
}
var file = new File('${tempDir.path}/foo.dart')..createSync();
file.writeAsStringSync("main() {}\n");
var dillFile = new File('${tempDir.path}/app.dill');
expect(dillFile.existsSync(), equals(false));
var depFile = new File('${tempDir.path}/depfile');
var depFile = new File('${tempDir.path}/the depfile');
expect(depFile.existsSync(), equals(false));
final List<String> args = <String>[
'--sdk-root=${sdkRoot.toFilePath()}',
@ -679,8 +676,8 @@ Future<int> main() async {
expect(depFile.existsSync(), true);
var depContents = depFile.readAsStringSync();
var depContentsParsed = depContents.split(':');
expect(depContentsParsed[0], dillFile.path);
var depContentsParsed = depContents.split(': ');
expect(path.basename(depContentsParsed[0]), path.basename(dillFile.path));
expect(depContentsParsed[1], isNotEmpty);
});
});