languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 17:04:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't compare typeArguments for FunctionType(s) equality.

Browse source 
Change-Id: I9245de1cc16f912af2141dee34b03f401d89a534
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106240
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Konstantin Shcheglov 2019-06-20 06:07:37 +00:00 committed by commit-bot@chromium.org
parent 6af218685e
commit a600e97cae
2 changed files with 1 additions and 118 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/analyzer/lib/src/dart/element/type.dart
View file

@ -13,7 +13,6 @@ import 'package:analyzer/src/generated/engine.dart'
show AnalysisContext, AnalysisEngine;
import 'package:analyzer/src/generated/resolver.dart';
import 'package:analyzer/src/generated/type_system.dart';
import 'package:analyzer/src/generated/utilities_collection.dart';
import 'package:analyzer/src/generated/utilities_dart.dart';
import 'package:analyzer/src/summary/resynthesize.dart'
show RecursiveInstantiateToBounds;
@ -725,8 +724,7 @@ abstract class FunctionTypeImpl extends TypeImpl implements FunctionType {
normalParameterTypes, object.normalParameterTypes) &&
TypeImpl.equalArrays(
optionalParameterTypes, object.optionalParameterTypes) &&
_equals(namedParameterTypes, object.namedParameterTypes) &&
TypeImpl.equalArrays(typeArguments, object.typeArguments);
_equals(namedParameterTypes, object.namedParameterTypes);
}
return false;
}
@ -2262,9 +2260,6 @@ class InterfaceTypeImpl extends TypeImpl implements InterfaceType {
List<DartType> newTypeArguments = TypeImpl.substitute(
typeArguments, argumentTypes, parameterTypes, prune);
if (listsEqual(newTypeArguments, typeArguments)) {
return this;
}
InterfaceTypeImpl newType =
new InterfaceTypeImpl(element, prune, nullabilitySuffix);

112
tests/compiler/dartdevc_native/debugger/debugger_test_golden.txt
View file

@ -1614,34 +1614,6 @@ Value:
]
]
],
[
"li",
{
"style": "padding-left: 13px;"
},
[
"span",
{
"style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
},
"toString: "
],
[
"span",
{
"style": "margin-left: 13px"
},
[
"object",
{
"object": "<OBJECT>",
"config": {
"name": "none"
}
}
]
]
],
[
"li",
{
@ -1698,34 +1670,6 @@ Value:
]
]
],
[
"li",
{
"style": "padding-left: 13px;"
},
[
"span",
{
"style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
},
"_equals: "
],
[
"span",
{
"style": "margin-left: 13px"
},
[
"object",
{
"object": "<OBJECT>",
"config": {
"name": "none"
}
}
]
]
],
[
"li",
{
@ -3307,34 +3251,6 @@ Value:
]
]
],
[
"li",
{
"style": "padding-left: 13px;"
},
[
"span",
{
"style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
},
"toString: "
],
[
"span",
{
"style": "margin-left: 13px"
},
[
"object",
{
"object": "<OBJECT>",
"config": {
"name": "none"
}
}
]
]
],
[
"li",
{
@ -3391,34 +3307,6 @@ Value:
]
]
],
[
"li",
{
"style": "padding-left: 13px;"
},
[
"span",
{
"style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
},
"_equals: "
],
[
"span",
{
"style": "margin-left: 13px"
},
[
"object",
{
"object": "<OBJECT>",
"config": {
"name": "none"
}
}
]
]
],
[
"li",
{