languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-01 18:04:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add requirement to fix downstream repositories

Browse source 
Closes https://github.com/dart-lang/sdk/pull/54982

Fixes: https://github.com/dart-lang/sdk/issues/54947
GitOrigin-RevId: ac418d660ebaf8966a55847bcd2e98ce464cebe2
Change-Id: I7bab8fa99dd3c438bb135635fb156f3510300fad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353660
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Matan Lurey <matanl@google.com>
This commit is contained in:
Alexander Thomas 2024-03-13 14:13:49 +00:00
parent e8a1fe81be
commit a5d0ee057e
1 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
docs/process/breaking-changes.md
View file

@ -105,9 +105,28 @@ impact changes.
### Step 3: Execution
If approved, the change may be made.
If approved, the breaking change is allowed to be made after ensuring the
`google3` and `flutter` repositories ("downstream") are not broken.
After the breaking change had been made, the person who made the change must:
The person making the change is expected to:
* Use code search to find obvious downstream breakages.
* Run presubmits provided by downstream teams to detect breakage.
* `google3`: Follow the instructions at go/dart-breaking-change.
* `flutter`: Add `flutter-` presubmits to your change to detect breakages.
* Fix the broken downstream code or attach a hotfix to the change.
After breakages are fixed, the approved change may be landed.
To land the change despite remaining breakages, request explicit approval for
these breakages in the breaking change issue. After these approvals are granted,
the change may be landed.
### Step 4: Finalization
After the breaking change has been made, the person who made the change must:
* Resolve the breaking change issue and make a note that the change has landed