languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 20:11:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart2js] Defer deserialized CodegenResults by members.

Browse source 
For large applications only ~60% of these objects are used. This defers their deserializtion until they're accessed in the codegen member map.

In local testing on large applications this saved ~200MB of memory usage in the linker phase.

Change-Id: I8ff87803fc23ef2d3f954646687e3fc67b68a4f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254600
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
This commit is contained in:
Nate Biggs 2022-08-15 16:13:46 +00:00 committed by Commit Bot
parent a304e5b156
commit a547cfc096
1 changed files with 17 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
pkg/compiler/lib/src/serialization/task.dart
View file

@ -28,6 +28,7 @@ import '../js_model/locals.dart';
import '../options.dart';
import '../util/sink_adapter.dart';
import '../world.dart';
import 'deferrable.dart';
import 'serialization.dart';
/// A data class holding some data [T] and the associated [DataSourceIndices].
@ -340,7 +341,7 @@ class SerializationTask extends CompilerTask {
sink.writeMemberMap(
results,
(MemberEntity member, CodegenResult result) =>
result.writeToDataSink(sink));
sink.writeDeferrable(() => result.writeToDataSink(sink)));
sink.close();
});
}
@ -353,7 +354,7 @@ class SerializationTask extends CompilerTask {
bool useDeferredSourceReads) async {
int shards = _options.codegenShards;
JClosedWorld closedWorld = globalTypeInferenceResults.closedWorld;
Map<MemberEntity, CodegenResult> results = {};
Map<MemberEntity, Deferrable<CodegenResult>> results = {};
for (int shard = 0; shard < shards; shard++) {
Uri uri = Uri.parse('${_options.readCodegenUri}$shard');
await measureIoSubtask('deserialize codegen', () async {
@ -368,7 +369,7 @@ class SerializationTask extends CompilerTask {
});
}
return DeserializedCodegenResults(
globalTypeInferenceResults, codegenInputs, results);
globalTypeInferenceResults, codegenInputs, DeferrableValueMap(results));
}
void _deserializeCodegenInput(
@ -377,7 +378,7 @@ class SerializationTask extends CompilerTask {
Uri uri,
api.Input<List<int>> dataInput,
DataSourceIndices importedIndices,
Map<MemberEntity, CodegenResult> results,
Map<MemberEntity, Deferrable<CodegenResult>> results,
bool useDeferredSourceReads) {
DataSourceReader source = DataSourceReader(
BinaryDataSource(dataInput.data, stringInterner: _stringInterner),
@ -386,17 +387,19 @@ class SerializationTask extends CompilerTask {
importedIndices: importedIndices,
useDeferredStrategy: useDeferredSourceReads);
backendStrategy.prepareCodegenReader(source);
Map<MemberEntity, CodegenResult> codegenResults =
Map<MemberEntity, Deferrable<CodegenResult>> codegenResults =
source.readMemberMap((MemberEntity member) {
List<ModularName> modularNames = [];
List<ModularExpression> modularExpressions = [];
CodegenReader reader =
CodegenReaderImpl(closedWorld, modularNames, modularExpressions);
source.registerCodegenReader(reader);
CodegenResult result = CodegenResult.readFromDataSource(
source, modularNames, modularExpressions);
source.deregisterCodegenReader(reader);
return result;
return source.readDeferrable(() {
List<ModularName> modularNames = [];
List<ModularExpression> modularExpressions = [];
CodegenReader reader =
CodegenReaderImpl(closedWorld, modularNames, modularExpressions);
source.registerCodegenReader(reader);
CodegenResult result = CodegenResult.readFromDataSource(
source, modularNames, modularExpressions);
source.deregisterCodegenReader(reader);
return result;
});
});
_reporter.log('Read ${codegenResults.length} members from ${uri}');
results.addAll(codegenResults);