languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 13:57:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use int.tryParse rather than deprecated onError parameter of int.parse.

Browse source 
Change-Id: I20943a59e367fa6bd328604063b4a736ec300c0e
Reviewed-on: https://dart-review.googlesource.com/58260
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This commit is contained in:
Paul Berry 2018-06-04 17:49:39 +00:00 committed by commit-bot@chromium.org
parent 2b5de60888
commit a518d3c6dc
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
runtime/observatory/lib/src/debugger/debugger_location.dart
View file

@ -75,8 +75,8 @@ class DebuggerLocation {
if (colStr != null) {
colStr = colStr.substring(1);
}
var line = int.parse(lineStr, onError: (_) => -1);
var col = (colStr != null ? int.parse(colStr, onError: (_) => -1) : null);
var line = int.tryParse(lineStr) ?? -1;
var col = (colStr != null ? int.tryParse(colStr) ?? -1 : null);
if (line == -1) {
return new Future.value(
new DebuggerLocation.error("Line '${lineStr}' must be an integer"));

2
runtime/observatory/lib/src/elements/debugger.dart
View file

@ -1008,7 +1008,7 @@ class IsolateCommand extends DebuggerCommand {
return new Future.value(null);
}
var arg = args[0].trim();
var num = int.parse(arg, onError: (_) => null);
var num = int.tryParse(arg);
var candidate;
for (var isolate in debugger.vm.isolates) {

2
runtime/observatory/lib/src/repositories/target.dart
View file

@ -117,7 +117,7 @@ class TargetRepository implements M.TargetRepository {
final Uri wsAddress = new Uri(
scheme: 'ws',
host: host ?? serverAddress.host,
port: int.parse(port ?? '', onError: (_) => serverAddress.port),
port: int.tryParse(port ?? '') ?? serverAddress.port,
path: '/ws',
);
return wsAddress.toString();

4
runtime/observatory/lib/src/service/object.dart
View file

@ -1624,7 +1624,7 @@ class Isolate extends ServiceObjectOwner implements M.Isolate {
void _update(Map map, bool mapIsRef) {
name = map['name'];
vmName = map.containsKey('_vmName') ? map['_vmName'] : name;
number = int.parse(map['number'], onError: (_) => null);
number = int.tryParse(map['number']);
if (mapIsRef) {
return;
}
@ -1632,7 +1632,7 @@ class Isolate extends ServiceObjectOwner implements M.Isolate {
loading = false;
runnable = map['runnable'] == true;
_upgradeCollection(map, isolate);
originNumber = int.parse(map['_originNumber'], onError: (_) => null);
originNumber = int.tryParse(map['_originNumber']);
rootLibrary = map['rootLib'];
if (map['entry'] != null) {
entry = map['entry'];