From a42380d3df47ec2236573b1020c01e198858cbf7 Mon Sep 17 00:00:00 2001 From: "ngeoffray@google.com" Date: Wed, 5 Oct 2011 12:35:03 +0000 Subject: [PATCH] Define runner before it is used. This allows running individual tests again: ./tools/test.py language/MyTest Review URL: https://chromereviews.googleplex.com/3508023 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35 260f80e4-7a28-3924-810f-c04153c831b5 --- tools/test.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/test.py b/tools/test.py index f3f6170afab..c77eb68f3fd 100755 --- a/tools/test.py +++ b/tools/test.py @@ -220,6 +220,7 @@ class BatchTester(object): def RunThread(self, batch_cmd, thread_number): """A thread started to feed a single TestRunner.""" try: + runner = None while not self.terminate and not self.work_queue.empty(): runner = subprocess.Popen(batch_cmd, stdin=subprocess.PIPE, @@ -229,7 +230,7 @@ class BatchTester(object): self.FeedTestRunner(runner, thread_number) if self.last_activity.has_key(thread_number): del self.last_activity[thread_number] - + # cleanup self.EndRunner(runner) @@ -239,7 +240,7 @@ class BatchTester(object): finally: if self.last_activity.has_key(thread_number): del self.last_activity[thread_number] - self.EndRunner(runner) + if runner: self.EndRunner(runner) def EndRunner(self, runner): """ Cleans up a single runner, killing the child if necessary""" @@ -251,7 +252,7 @@ class BatchTester(object): for (found_runner, thread_number) in self.runners.items(): if runner == found_runner: del self.runners[thread_number] - break + break try: runner.communicate(); except ValueError: