languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Attempt at capturing screenshot on IE if tests time out

Browse source 
The hypothesis is that a modal dialog from Internet Explorer causes
the currently running test to hang until test.dart kills the browser.

Capturing a screenshot might give an insight into there is a dialog showing up.

BUG=https://github.com/dart-lang/sdk/issues/28955
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2811093003 .
This commit is contained in:
Martin Kustermann 2017-04-12 10:57:54 +02:00
parent aef0c45019
commit a3e9cd8ff6
2 changed files with 101 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
tools/capture_screenshot.ps1 Normal file
View file

@ -0,0 +1,20 @@
# Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
[Reflection.Assembly]::LoadWithPartialName("System.Drawing")
function screenshot([Drawing.Rectangle]$bounds, $path) {
$bmp = New-Object Drawing.Bitmap $bounds.width, $bounds.height
$graphics = [Drawing.Graphics]::FromImage($bmp)
$graphics.CopyFromScreen(
$bounds.Location, [Drawing.Point]::Empty, $bounds.size)
$bmp.Save($path)
$graphics.Dispose()
$bmp.Dispose()
}
$bounds = [Drawing.Rectangle]::FromLTRB(0, 0, 2000, 4000)
screenshot $bounds $args[0]

108
tools/testing/dart/browser_controller.dart
View file

@ -1130,7 +1130,7 @@ class BrowserTestRunner {
}
}
void handleTimeout(BrowserStatus status) {
Future handleTimeout(BrowserStatus status) async {
// We simply kill the browser and starts up a new one!
// We could be smarter here, but it does not seems like it is worth it.
if (status.timeout) {
@ -1142,33 +1142,39 @@ class BrowserTestRunner {
var id = status.browser.id;
status.currentTest.stopwatch.stop();
status.browser.close().then((_) {
var lastKnownMessage =
'Dom could not be fetched, since the test timed out.';
if (status.currentTest.lastKnownMessage.length > 0) {
lastKnownMessage = status.currentTest.lastKnownMessage;
}
if (status.lastTest != null) {
lastKnownMessage += '\nPrevious test was ${status.lastTest.url}';
}
// Wait until the browser is closed before reporting the test as timeout.
// This will enable us to capture stdout/stderr from the browser
// (which might provide us with information about what went wrong).
var browserTestOutput = new BrowserTestOutput(
status.currentTest.delayUntilTestStarted,
status.currentTest.stopwatch.elapsed,
lastKnownMessage,
status.browser.testBrowserOutput,
didTimeout: true);
status.currentTest.doneCallback(browserTestOutput);
status.lastTest = status.currentTest;
status.currentTest = null;
// We don't want to start a new browser if we are terminating.
if (underTermination) return;
removeBrowser(id);
requestBrowser();
});
// Before closing the browser, we'll try to capture a screenshot on
// windows when using IE (to debug flakiness).
if (status.browser is IE) {
await captureInternetExplorerScreenshot(
'IE screenshot for ${status.currentTest.url}');
}
await status.browser.close();
var lastKnownMessage =
'Dom could not be fetched, since the test timed out.';
if (status.currentTest.lastKnownMessage.length > 0) {
lastKnownMessage = status.currentTest.lastKnownMessage;
}
if (status.lastTest != null) {
lastKnownMessage += '\nPrevious test was ${status.lastTest.url}';
}
// Wait until the browser is closed before reporting the test as timeout.
// This will enable us to capture stdout/stderr from the browser
// (which might provide us with information about what went wrong).
var browserTestOutput = new BrowserTestOutput(
status.currentTest.delayUntilTestStarted,
status.currentTest.stopwatch.elapsed,
lastKnownMessage,
status.browser.testBrowserOutput,
didTimeout: true);
status.currentTest.doneCallback(browserTestOutput);
status.lastTest = status.currentTest;
status.currentTest = null;
// We don't want to start a new browser if we are terminating.
if (underTermination) return;
removeBrowser(id);
requestBrowser();
}
/// Remove a browser that has closed from our data structures that track
@ -1884,3 +1890,51 @@ body div {
return driverContent;
}
}
Future captureInternetExplorerScreenshot(String message) async {
if (Platform.environment['USERNAME'] != 'chrome-bot') {
return;
}
print('--------------------------------------------------------------------');
final String date =
new DateTime.now().toUtc().toIso8601String().replaceAll(':', '_');
final screenshotName = 'ie_screenshot_${date}.png';
// The "capture_screen.ps1" script is next to "test.dart" in "tools/"
final powerShellScript =
Platform.script.resolve('capture_screenshot.ps1').toFilePath();
final screenshotFile =
Platform.script.resolve('../$screenshotName').toFilePath();
final args = [powerShellScript, screenshotFile];
final ProcessResult result =
await Process.run('powershell.exe', args, runInShell: true);
if (result.exitCode != 0) {
print('[$message] Failed to capture IE screenshot on windows: '
'powershell.exe "${args.join(' ')}" returned with:\n'
'exit code: ${result.exitCode}\n'
'stdout: ${result.stdout}\n'
'stderr: ${result.stderr}');
} else {
final storageUrl = 'gs://dart-temp-crash-archive/$screenshotName';
final args = [
r'e:\b\depot_tools\gsutil.py',
'cp',
screenshotFile,
storageUrl,
];
final ProcessResult result = await Process.run('python', args);
if (result.exitCode != 0) {
print('[$message] Failed upload captured IE screenshot to cloud storage: '
'"${args.join(' ')}" returned with:\n'
'exit code: ${result.exitCode}\n'
'stdout: ${result.stdout}\n'
'stderr: ${result.stderr}');
} else {
print('[$message] Successfully uploaded screenshot to $storageUrl');
}
new File(screenshotFile).deleteSync();
}
print('--------------------------------------------------------------------');
}