From a2f43064dc24a6ca5fab503332a4d84e94aa83be Mon Sep 17 00:00:00 2001 From: "regis@google.com" Date: Tue, 5 May 2015 10:11:41 +0000 Subject: [PATCH] Fix Bigint_rsh on mips (was obviously not properly tested). Review URL: https://codereview.chromium.org//1124553006 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45522 260f80e4-7a28-3924-810f-c04153c831b5 --- runtime/vm/intrinsifier_mips.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/runtime/vm/intrinsifier_mips.cc b/runtime/vm/intrinsifier_mips.cc index 558454b2aca..a9e2872fb77 100644 --- a/runtime/vm/intrinsifier_mips.cc +++ b/runtime/vm/intrinsifier_mips.cc @@ -868,9 +868,12 @@ void Intrinsifier::Bigint_rsh(Assembler* assembler) { // T2 = 32 - T3 __ subu(T2, ZR, T3); __ addiu(T2, T2, Immediate(32)); + // T1 = x_digits[n ~/ _DIGIT_BITS] >> (n % _DIGIT_BITS) + __ lw(T1, Address(V0, 0)); + __ addiu(V0, V0, Immediate(Bigint::kBytesPerDigit)); Label loop_exit; __ beq(V1, T6, &loop_exit); - __ delay_slot()->mov(T1, ZR); + __ delay_slot()->srlv(T1, T1, T3); Label loop; __ Bind(&loop); __ lw(T0, Address(V0, 0));