languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 11:03:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

guard against empty entity lists

Browse source 
Unable to repro the reported issue, but this will at least protect against the exception.

Fixes: https://dart-review.googlesource.com/c/sdk/+/359280

Change-Id: I712f9b92879ca6b80b2f1004206e4f77a3178a47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359280
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This commit is contained in:
pq 2024-03-22 23:02:33 +00:00 committed by Commit Queue
parent 970582ec20
commit a19c07ffd4
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/analysis_server/lib/src/services/correction/dart/split_multiple_declarations.dart
View file

@ -34,6 +34,7 @@ class SplitMultipleDeclarations extends ResolvedCorrectionProducer {
final hasMetadata = variableList.metadata.isNotEmpty;
final parent = variableList.parent;
// TODO(sstasi95): consider fields
final hasParentMetadata =
(parent is TopLevelVariableDeclaration) && parent.metadata.isNotEmpty;
@ -49,6 +50,10 @@ class SplitMultipleDeclarations extends ResolvedCorrectionProducer {
final entities = variableList.childEntities
.where((e) => e is KeywordToken || e is NamedType);
if (entities.isEmpty) {
return;
}
final entitiesRange = range.startEnd(entities.first, entities.last);
final keywordsAndType = utils.getRangeText(entitiesRange);