languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 02:07:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Migration: disable "apply migration" button after handleAddHintLinkClick

Browse source 
Prevents file corruption if the user adds hints and then tries to
apply the migration result without running migration to account for
the hints.

Fixes #45571.

Bug: https://github.com/dart-lang/sdk/issues/45571
Change-Id: Id11584a1d8b7a6b35127ad828d37b3ef837a5e65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194009
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This commit is contained in:
Paul Berry 2021-04-06 05:12:56 +00:00 committed by commit-bot@chromium.org
parent 0291de4bcf
commit a15e9bc3d2
2 changed files with 3270 additions and 3268 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6537
pkg/nnbd_migration/lib/src/front_end/resources/resources.g.dart
View file

File diff suppressed because it is too large Load diff

1
pkg/nnbd_migration/lib/src/front_end/web/migration.dart
View file

@ -356,6 +356,7 @@ void handleAddHintLinkClick(MouseEvent event) async {
// the response.
await doPost(path);
await loadFile(window.location.pathname, null, null, false);
document.body.classes.add('needs-rerun');
_scrollContentTo(previousScrollPosition);
} catch (e, st) {
handleError("couldn't add/remove hint", e, st);