languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:30:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

[graphexplorer] Rename bounds variables for successor and predecessor iteration.

Browse source 
Based on suggestion from code review.

Change-Id: I51b3dbbd6f9822842f154cd90c9a020194ed16f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266443
Reviewed-by: Derek Xu <derekx@google.com>
This commit is contained in:
Ryan Macnak 2022-10-28 20:07:24 +00:00
parent c7ebfde808
commit a1089367cc
1 changed files with 33 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

66
runtime/tools/graphexplorer/graphexplorer.js
View file

@ -340,10 +340,10 @@ Graph.prototype.computePredecessors = function() {
const predecessorCount = new Uint32Array(N + 1); const predecessorCount = new Uint32Array(N + 1);
for (let i = 1; i <= N; i++) { for (let i = 1; i <= N; i++) {
let firstSuccessorIndex = firstSuccessor[i]; let startSuccessorIndex = firstSuccessor[i];
let lastSuccessorIndex = firstSuccessor[i + 1]; let limitSuccessorIndex = firstSuccessor[i + 1];
for (let successorIndex = firstSuccessorIndex; for (let successorIndex = startSuccessorIndex;
successorIndex < lastSuccessorIndex; successorIndex < limitSuccessorIndex;
successorIndex++) { successorIndex++) {
let successor = successors[successorIndex]; let successor = successors[successorIndex];
if (successor == 0) continue; // Omitted object. if (successor == 0) continue; // Omitted object.
@ -359,10 +359,10 @@ Graph.prototype.computePredecessors = function() {
firstPredecessor[N + 1] = nextPredecessorIndex; firstPredecessor[N + 1] = nextPredecessorIndex;
for (let i = 1; i <= N; i++) { for (let i = 1; i <= N; i++) {
let firstSuccessorIndex = firstSuccessor[i]; let startSuccessorIndex = firstSuccessor[i];
let lastSuccessorIndex = firstSuccessor[i + 1]; let limitSuccessorIndex = firstSuccessor[i + 1];
for (let successorIndex = firstSuccessorIndex; for (let successorIndex = startSuccessorIndex;
successorIndex < lastSuccessorIndex; successorIndex < limitSuccessorIndex;
successorIndex++) { successorIndex++) {
let successor = successors[successorIndex]; let successor = successors[successorIndex];
if (successor == 0) continue; // Omitted object. if (successor == 0) continue; // Omitted object.
@ -424,10 +424,10 @@ Graph.prototype.rewriteEdgesForOwners = function() {
continue; continue;
} }
let firstSuccessorIndex = firstSuccessor[i]; let startSuccessorIndex = firstSuccessor[i];
let lastSuccessorIndex = firstSuccessor[i + 1]; let limitSuccessorIndex = firstSuccessor[i + 1];
for (let successorIndex = firstSuccessorIndex; for (let successorIndex = startSuccessorIndex;
successorIndex < lastSuccessorIndex; successorIndex < limitSuccessorIndex;
successorIndex++) { successorIndex++) {
let edge = this.strings_[this.successorName_[successorIndex]]; let edge = this.strings_[this.successorName_[successorIndex]];
if (edge == ownerEdgeName) { if (edge == ownerEdgeName) {
@ -445,11 +445,11 @@ Graph.prototype.rewriteEdgesForOwners = function() {
const newSuccessorName = new Uint32Array(E); const newSuccessorName = new Uint32Array(E);
let newSuccessorIndex = 0; let newSuccessorIndex = 0;
for (let i = 1; i <= N; i++) { for (let i = 1; i <= N; i++) {
let firstSuccessorIndex = firstSuccessor[i]; let startSuccessorIndex = firstSuccessor[i];
let lastSuccessorIndex = firstSuccessor[i + 1]; let limitSuccessorIndex = firstSuccessor[i + 1];
firstSuccessor[i] = newSuccessorIndex; firstSuccessor[i] = newSuccessorIndex;
for (let successorIndex = firstSuccessorIndex; for (let successorIndex = startSuccessorIndex;
successorIndex < lastSuccessorIndex; successorIndex < limitSuccessorIndex;
successorIndex++) { successorIndex++) {
let successor = successors[successorIndex]; let successor = successors[successorIndex];
let name = successorName[successorIndex]; let name = successorName[successorIndex];
@ -475,14 +475,14 @@ Graph.prototype.rewriteEdgesForOwners = function() {
continue; continue;
} }
let firstPredecessorIndex = firstPredecessor[i]; let startPredecessorIndex = firstPredecessor[i];
let lastPredecessorIndex = firstPredecessor[i + 1]; let limitPredecessorIndex = firstPredecessor[i + 1];
for (let predecessorIndex = firstPredecessorIndex; for (let predecessorIndex = startPredecessorIndex;
predecessorIndex < lastPredecessorIndex; predecessorIndex < limitPredecessorIndex;
predecessorIndex++) { predecessorIndex++) {
predecessors[predecessorIndex] = 0; predecessors[predecessorIndex] = 0;
} }
predecessors[firstPredecessorIndex] = owner; predecessors[startPredecessorIndex] = owner;
let nextSuccessorIndex = firstSuccessor[owner + 1] - owneeCount[owner]; let nextSuccessorIndex = firstSuccessor[owner + 1] - owneeCount[owner];
newSuccessors[nextSuccessorIndex] = i; newSuccessors[nextSuccessorIndex] = i;
@ -592,10 +592,10 @@ Graph.prototype.computeDominators = function() {
let w = vertex[i]; let w = vertex[i];
// Lengauer and Tarjan Step 2. // Lengauer and Tarjan Step 2.
let firstPredecessorIndex = firstPredecessor[w]; let startPredecessorIndex = firstPredecessor[w];
let lastPredecessorIndex = firstPredecessor[w + 1]; let limitPredecessorIndex = firstPredecessor[w + 1];
for (let predecessorIndex = firstPredecessorIndex; for (let predecessorIndex = startPredecessorIndex;
predecessorIndex < lastPredecessorIndex; predecessorIndex < limitPredecessorIndex;
predecessorIndex++) { predecessorIndex++) {
let v = predecessors[predecessorIndex]; let v = predecessors[predecessorIndex];
@ -978,10 +978,10 @@ function removeDuplicates(array) {
Graph.prototype.successorsOfDo = function(v, action) { Graph.prototype.successorsOfDo = function(v, action) {
let cls = this.class_[v]; let cls = this.class_[v];
let firstSuccessorIndex = this.firstSuccessor_[v]; let startSuccessorIndex = this.firstSuccessor_[v];
let lastSuccessorIndex = this.firstSuccessor_[v + 1]; let limitSuccessorIndex = this.firstSuccessor_[v + 1];
for (let successorIndex = firstSuccessorIndex; for (let successorIndex = startSuccessorIndex;
successorIndex < lastSuccessorIndex; successorIndex < limitSuccessorIndex;
successorIndex++) { successorIndex++) {
let successor = this.successors_[successorIndex]; let successor = this.successors_[successorIndex];
let edgeName = this.strings_[this.successorName_[successorIndex]]; let edgeName = this.strings_[this.successorName_[successorIndex]];
@ -991,10 +991,10 @@ Graph.prototype.successorsOfDo = function(v, action) {
} }
Graph.prototype.predecessorsOfDo = function(v, action) { Graph.prototype.predecessorsOfDo = function(v, action) {
let firstPredecessorIndex = this.firstPredecessor_[v]; let startPredecessorIndex = this.firstPredecessor_[v];
let lastPredecessorIndex = this.firstPredecessor_[v + 1]; let limitPredecessorIndex = this.firstPredecessor_[v + 1];
for (let predecessorIndex = firstPredecessorIndex; for (let predecessorIndex = startPredecessorIndex;
predecessorIndex < lastPredecessorIndex; predecessorIndex < limitPredecessorIndex;
predecessorIndex++) { predecessorIndex++) {
let predecessor = this.predecessors_[predecessorIndex]; let predecessor = this.predecessors_[predecessorIndex];
let cls = this.class_[predecessor]; let cls = this.class_[predecessor];