languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 09:54:38 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[dart2wasm] Use unchecked codeUnitAt in int.parse

Browse source 
Change-Id: I60c2a9a56ce9693061054fd72005e52fc6889aab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372901
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
This commit is contained in:
Ömer Sinan Ağacan 2024-06-24 13:40:08 +00:00 committed by Commit Queue
parent 43452cdd6c
commit 9fbe418aa3
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
sdk/lib/_internal/wasm/lib/int_patch.dart
View file

@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
import "dart:_internal" show has63BitSmis, patch, unsafeCast;
import "dart:_string" show StringUncheckedOperations;
import "dart:typed_data" show Int64List;
@patch
@ -11,7 +12,7 @@ class int {
assert(first <= last);
var ix = first;
var sign = 1;
var c = str.codeUnitAt(ix);
var c = str.codeUnitAtUnchecked(ix);
// Check for leading '+' or '-'.
if ((c == 0x2b) || (c == 0x2d)) {
ix++;
@ -26,7 +27,7 @@ class int {
}
var result = 0;
for (int i = ix; i <= last; i++) {
var c = 0x30 ^ str.codeUnitAt(i);
var c = 0x30 ^ str.codeUnitAtUnchecked(i);
if (9 < c) {
return null;
}
@ -60,7 +61,7 @@ class int {
}
int start = source.firstNonWhitespace();
int first = source.codeUnitAt(start);
int first = source.codeUnitAtUnchecked(start);
int sign = 1;
if (first == 0x2b /* + */ || first == 0x2d /* - */) {
sign = 0x2c - first; // -1 if '-', +1 if '+'.
@ -68,7 +69,7 @@ class int {
if (start == end) {
return _handleFormatError(onError, source, end, radix, null);
}
first = source.codeUnitAt(start);
first = source.codeUnitAtUnchecked(start);
}
if (radix == null) {
// check for 0x prefix.
@ -76,7 +77,7 @@ class int {
if (first == 0x30 /* 0 */) {
index++;
if (index == end) return 0;
first = source.codeUnitAt(index);
first = source.codeUnitAtUnchecked(index);
if ((first | 0x20) == 0x78 /* x */) {
index++;
if (index == end) {
@ -196,13 +197,13 @@ class int {
_Smi result = unsafeCast<_Smi>(0);
if (radix <= 10) {
for (int i = start; i < end; i++) {
int digit = source.codeUnitAt(i) ^ 0x30;
int digit = source.codeUnitAtUnchecked(i) ^ 0x30;
if (digit >= radix) return null;
result = (radix * result + digit) as _Smi;
}
} else {
for (int i = start; i < end; i++) {
int char = source.codeUnitAt(i);
int char = source.codeUnitAtUnchecked(i);
int digit = char ^ 0x30;
if (digit > 9) {
digit = (char | 0x20) - (0x61 - 10);