languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-07 18:07:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Strict-inference: be lenient on @optionalTypeArgs classes

Browse source 
Fixes https://github.com/dart-lang/sdk/issues/42882

Change-Id: I01c7b12cdb36d06ab9d44fb080b15b30684cba3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This commit is contained in:
Sam Rawlins 2020-07-30 22:48:04 +00:00 committed by commit-bot@chromium.org
parent c6deb3793f
commit 9f49ef9d82
2 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/analyzer/lib/src/dart/element/generic_inferrer.dart
View file

@ -224,7 +224,10 @@ class GenericInferrer {
// by [infer], with [typeParam] filled in as its bounds. This is
// considered a failure of inference, under the "strict-inference"
// mode.
if (errorNode is ConstructorName) {
if (errorNode is ConstructorName &&
!(errorNode.type.type as InterfaceType)
.element
.hasOptionalTypeArgs) {
String constructorName = errorNode.name == null
? errorNode.type.name.name
: '${errorNode.type}.${errorNode.name}';

16
pkg/analyzer/test/src/diagnostics/inference_failure_on_instance_creation_test.dart
View file

@ -4,6 +4,7 @@
import 'package:analyzer/src/error/codes.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/test_utilities/package_mixin.dart';
import 'package:test/test.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
@ -16,7 +17,8 @@ main() {
}
@reflectiveTest
class InferenceFailureOnInstanceCreationTest extends DriverResolutionTest {
class InferenceFailureOnInstanceCreationTest extends DriverResolutionTest
with PackageMixin {
@override
AnalysisOptionsImpl get analysisOptions =>
AnalysisOptionsImpl()..strictInference = true;
@ -74,6 +76,18 @@ void f() {
]);
}
test_missingTypeArgument_noInference_optionalTypeArgs() async {
addMetaPackage();
await assertNoErrorsInCode(r'''
import 'package:meta/meta.dart';
@optionalTypeArgs
class C<T> {}
void f() {
C();
}
''');
}
test_missingTypeArgument_upwardInference() async {
await assertNoErrorsInCode(r'''
import 'dart:collection';