languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 12:48:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for 23806 - don't optimize out Array allocation that may throw

Browse source 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1431513012 .
This commit is contained in:
Stephen Adams 2015-11-05 18:11:23 -08:00
parent b3a4cc337c
commit 9efe59cc02
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
pkg/compiler/lib/src/ssa/builder.dart
View file

@ -5159,12 +5159,15 @@ class SsaBuilder extends ast.Visitor
js.Template code = js.js.parseForeignJS('new Array(#)');
var behavior = new native.NativeBehavior();
behavior.typesReturned.add(expectedType);
// The allocation can throw only if the given length is a double
// or negative.
// The allocation can throw only if the given length is a double or
// outside the unsigned 32 bit range.
// TODO(sra): Array allocation should be an instruction so that canThrow
// can depend on a length type discovered in optimization.
bool canThrow = true;
if (inputs[0].isInteger(compiler) && inputs[0] is HConstant) {
var constant = inputs[0];
if (constant.constant.primitiveValue >= 0) canThrow = false;
int value = constant.constant.primitiveValue;
if (0 <= value && value < 0x100000000) canThrow = false;
}
HForeignCode foreign = new HForeignCode(code, elementType, inputs,
nativeBehavior: behavior,