languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 18:05:01 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[observatory] Include observatory main.dart.js.map with debug build.

Browse source 
Having this map file allows for the browser to report source line numbers in case of exception thrown by Observatory code.

Change-Id: Ia47789b89b3a14ca6513143bf9d4cc9c4a8cc1fb
Reviewed-on: https://dart-review.googlesource.com/68847
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
This commit is contained in:
Alexander Aprelev 2018-08-08 17:21:34 +00:00 committed by commit-bot@chromium.org
parent 7eda513405
commit 9e9adcef57
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
runtime/observatory/BUILD.gn
View file

@ -19,6 +19,9 @@ prebuilt_dart2js_action("build_observatory") {
outputs = [
output,
]
if (is_debug) {
outputs += [ "$target_gen_dir/observatory/web/main.dart.js.map" ]
}
version_string = exec_script("../../tools/make_version.py",
[
@ -60,7 +63,6 @@ observatory_ignore_patterns = [
"*.concat.js",
"*.dart",
"*.log",
"*.map",
"*.precompiled.js",
"*.scriptUrls",
"*_buildLogs*",
@ -78,6 +80,10 @@ observatory_ignore_patterns = [
"webcomponents.*",
]
if (!is_debug) {
observatory_ignore_patterns += [ "*.map" ]
}
# The ignore_patterns entry in the scopes accepted by copy_trees() is a
# string of comma delimited patterns.
observatory_ignore_string = "\$sdk"
@ -157,8 +163,11 @@ copy("copy_main_dart_js") {
sources = [
"$target_gen_dir/observatory/web/main.dart.js",
]
if (is_debug) {
sources += [ "$target_gen_dir/observatory/web/main.dart.js.map" ]
}
outputs = [
"$target_out_dir/observatory/deployed/web/main.dart.js",
"$target_out_dir/observatory/deployed/web/{{source_file_part}}",
]
}