languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 09:58:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

[vm] Fix memory leak freeing boringssl stack types.

Browse source 
TEST=lsan
Bug: https://github.com/dart-lang/sdk/issues/54765
Change-Id: Ibd22bb77d2941da33ac3afeb1ab8c7c0bcd3d267
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349411
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak 2024-01-31 19:24:29 +00:00 committed by Commit Queue
parent 2998703466
commit 9d3e923bf3
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
runtime/bin/secure_socket_utils.h
View file

@ -152,8 +152,8 @@ class ScopedSSLStackType {
~ScopedSSLStackType() {
if (obj_ != nullptr) {
func(reinterpret_cast<E*>(
OPENSSL_sk_pop(reinterpret_cast<OPENSSL_STACK*>(obj_))));
OPENSSL_sk_pop_free_ex(reinterpret_cast<OPENSSL_STACK*>(obj_),
call_free_func, free_func);
}
}
@ -167,6 +167,11 @@ class ScopedSSLStackType {
}
private:
static void free_func(void* element) { func(reinterpret_cast<E*>(element)); }
static void call_free_func(void (*free_func)(void*), void* element) {
free_func(element);
}
T* obj_;
DISALLOW_ALLOCATION();