From 9cf61baf5793e574fa27939c109ecdd6709f4ed4 Mon Sep 17 00:00:00 2001 From: Nicholas Shahan Date: Tue, 20 Jul 2021 19:44:01 +0000 Subject: [PATCH] [ddc] Update webkit_inspection_protocol dep - New version has been migrated to null safety. - Update tests that are currently broken. It looks like a CFE bug was fixed and now the private static fields are accessible. Change-Id: I3d9bde85b65c0e219f756df2d9531539eb7f732b Issue: https://github.com/dart-lang/sdk/issues/46617 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207382 Reviewed-by: Mark Zhou Commit-Queue: Nicholas Shahan --- .dart_tool/package_config.json | 2 +- DEPS | 2 +- .../expression_compiler/expression_compiler_e2e_shared.dart | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.dart_tool/package_config.json b/.dart_tool/package_config.json index 546ad7adc9c..c3b657c18a3 100644 --- a/.dart_tool/package_config.json +++ b/.dart_tool/package_config.json @@ -797,7 +797,7 @@ "name": "webkit_inspection_protocol", "rootUri": "../third_party/pkg/webkit_inspection_protocol", "packageUri": "lib/", - "languageVersion": "2.0" + "languageVersion": "2.12" }, { "name": "yaml", diff --git a/DEPS b/DEPS index a11c6606ff8..3d15b954112 100644 --- a/DEPS +++ b/DEPS @@ -174,7 +174,7 @@ vars = { "web_socket_channel_rev": "6448ce532445a8a458fa191d9346df071ae0acad", "WebCore_rev": "fb11e887f77919450e497344da570d780e078bc8", "webdev_rev": "b0aae7b6944d484722e6af164abedd864a2a0afa", - "webkit_inspection_protocol_rev": "6b15729292d030f2e5c5861022da4c5a4c11961c", + "webkit_inspection_protocol_rev": "dd6fb5d8b536e19cedb384d0bbf1f5631923f1e8", "yaml_rev": "b4c4411631bda556ce9a45af1ab0eecaf9f3ac53", "zlib_rev": "bf44340d1b6be1af8950bbdf664fec0cf5a831cc", "crashpad_rev": "bf327d8ceb6a669607b0dbab5a83a275d03f99ed", diff --git a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart b/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart index 1e1f94dd04b..40f3f36a7ad 100644 --- a/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart +++ b/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_shared.dart @@ -420,7 +420,7 @@ void runSharedTests(SetupCompilerOptions setup, TestDriver driver) { await driver.check( breakpointId: 'globalFunctionBP', expression: 'C._staticField', - expectedError: "Error: Getter not found: '_staticField'."); + expectedResult: '2'); }); test('access field', () async { @@ -476,7 +476,7 @@ void runSharedTests(SetupCompilerOptions setup, TestDriver driver) { await driver.check( breakpointId: 'globalFunctionBP', expression: 'C._staticField = 2', - expectedError: "Setter not found: '_staticField'."); + expectedResult: '2'); }); test('static field modification', () async {