languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:21:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[infra] Upgrade Chrome to 91

Browse source 
* Sort command line options passed to chrome.
* Add --disable-component-updates to reduce flakiness from self-updates.
* Add --use-mock-keychain to avoid modal permissions dialog on macOS.

Change-Id: I63bf4895c219efe691af683dab527a036a8e018b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203520
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This commit is contained in:
Alexander Thomas 2021-06-21 06:30:27 +00:00
parent b929c66393
commit 9bcebce220
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
DEPS
View file

@ -105,7 +105,6 @@ vars = {
# For more details, see https://github.com/dart-lang/sdk/issues/30164 # For more details, see https://github.com/dart-lang/sdk/issues/30164
"dart_style_rev": "f17c23e0eea9a870601c19d904e2a9c1a7c81470", "dart_style_rev": "f17c23e0eea9a870601c19d904e2a9c1a7c81470",
"chromedriver_tag": "83.0.4103.39",
"dartdoc_rev" : "b733d4952dbd25374d55e28476a5f44bd60ed63f", "dartdoc_rev" : "b733d4952dbd25374d55e28476a5f44bd60ed63f",
"devtools_rev" : "b3bf672474a2bff82f33e1176aa803539baa0d60+1", "devtools_rev" : "b3bf672474a2bff82f33e1176aa803539baa0d60+1",
"jsshell_tag": "version:88.0", "jsshell_tag": "version:88.0",
@ -185,7 +184,7 @@ vars = {
# Pinned browser versions used by the testing infrastructure. These are not # Pinned browser versions used by the testing infrastructure. These are not
# meant to be downloaded by users for local testing. # meant to be downloaded by users for local testing.
"download_chrome": False, "download_chrome": False,
"chrome_tag": "84", "chrome_tag": "91",
"download_firefox": False, "download_firefox": False,
"firefox_tag": "67", "firefox_tag": "67",
} }
@ -523,7 +522,7 @@ deps = {
"packages": [ "packages": [
{ {
"package": "dart/third_party/chromedriver/${{platform}}", "package": "dart/third_party/chromedriver/${{platform}}",
"version": "version:" + Var("chromedriver_tag"), "version": "version:" + Var("chrome_tag"),
} }
], ],
"condition": "host_cpu == 'x64'", "condition": "host_cpu == 'x64'",

8
pkg/test_runner/lib/src/browser_controller.dart
View file

@ -462,12 +462,14 @@ class Chrome extends Browser {
} }
}; };
var args = [ var args = [
"--user-data-dir=${userDir.path}", "--bwsi",
url, "--disable-component-update",
"--disable-extensions", "--disable-extensions",
"--disable-popup-blocking", "--disable-popup-blocking",
"--bwsi",
"--no-first-run", "--no-first-run",
"--use-mock-keychain",
"--user-data-dir=${userDir.path}",
url,
]; ];
// TODO(rnystrom): Uncomment this to open the dev tools tab when Chrome // TODO(rnystrom): Uncomment this to open the dev tools tab when Chrome