languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 21:50:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add constructor references to ConstructorElement indexing tests.

Browse source 
Change-Id: I0d62d43eb0663e6c65adb08e7c5f8bda49790b9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Konstantin Shcheglov 2021-09-03 21:27:18 +00:00 committed by commit-bot@chromium.org
parent d0935c2c85
commit 9b3a91a515
2 changed files with 96 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/analyzer/lib/src/dart/analysis/index.dart
View file

@ -741,7 +741,7 @@ class _IndexContributor extends GeneralizingAstVisitor {
recordRelationOffset(
element, IndexRelationKind.IS_REFERENCED_BY, offset, 0, true);
}
super.visitRedirectingConstructorInvocation(node);
node.argumentList.accept(this);
}
@override

139
pkg/analyzer/test/src/dart/analysis/index_test.dart
View file

@ -659,43 +659,6 @@ part 'b.dart';
// No exception, even though a.dart is a part of b.dart part.
}
test_isReferencedBy_ConstructorElement() async {
await _indexTestUnit('''
/// [new A.foo] 1
/// [A.foo] 2
/// [new A] 3
class A implements B {
A() {}
A.foo() {}
}
class B extends A {
B() : super(); // 4
B.foo() : super.foo(); // 5
factory B.bar() = A.foo; // 6
}
main() {
new A(); // 7
new A.foo(); // 8
}
''');
var constA = findElement.unnamedConstructor('A');
var constA_foo = findElement.constructor('foo', of: 'A');
// A()
assertThat(constA)
..hasRelationCount(3)
..isReferencedAt('] 3', true, length: 0)
..isReferencedAt('(); // 4', true, length: 0)
..isReferencedAt('(); // 7', true, length: 0);
// A.foo()
assertThat(constA_foo)
..hasRelationCount(5)
..isReferencedAt('.foo] 1', true, length: 4)
..isReferencedAt('.foo] 2', true, length: 4)
..isReferencedAt('.foo(); // 5', true, length: 4)
..isReferencedAt('.foo; // 6', true, length: 4)
..isReferencedAt('.foo(); // 8', true, length: 4);
}
test_isReferencedBy_ConstructorElement_classTypeAlias() async {
await _indexTestUnit('''
class M {}
@ -735,6 +698,33 @@ main() {
// No additional validation, but it should not fail with stack overflow.
}
test_isReferencedBy_ConstructorElement_named() async {
await _indexTestUnit('''
/// [new A.foo] 1
class A {
A.foo() {}
A.bar() : this.foo(); // 2
}
class B extends A {
B() : super.foo(); // 3
factory B.bar() = A.foo; // 4
}
void f() {
A.foo(); // 5
A.foo; // 6
}
''');
var element = findElement.constructor('foo');
assertThat(element)
..hasRelationCount(6)
..isReferencedAt('.foo] 1', true, length: 4)
..isReferencedAt('.foo(); // 2', true, length: 4)
..isReferencedAt('.foo(); // 3', true, length: 4)
..isReferencedAt('.foo; // 4', true, length: 4)
..isReferencedAt('.foo(); // 5', true, length: 4)
..isReferencedAt('.foo; // 6', true, length: 4);
}
test_isReferencedBy_ConstructorElement_namedOnlyWithDot() async {
await _indexTestUnit('''
class A {
@ -766,16 +756,77 @@ class A {
assertThat(constA_bar).isReferencedAt('.bar(); // 1', true, length: 4);
}
test_isReferencedBy_ConstructorElement_synthetic() async {
test_isReferencedBy_ConstructorElement_unnamed_declared() async {
await _indexTestUnit('''
class A {}
main() {
new A(); // 1
/// [new A] 1
class A {
A() {}
}
class B extends A {
B() : super(); // 2
factory B.bar() = A; // 3
}
void f() {
A(); // 4
A.new; // 5
}
''');
var constA = findElement.unnamedConstructor('A');
// A()
assertThat(constA)..isReferencedAt('(); // 1', true, length: 0);
var element = findElement.unnamedConstructor('A');
assertThat(element)
..hasRelationCount(5)
..isReferencedAt('] 1', true, length: 0)
..isReferencedAt('(); // 2', true, length: 0)
..isReferencedAt('; // 3', true, length: 0)
..isReferencedAt('(); // 4', true, length: 0)
..isReferencedAt('.new; // 5', true, length: 4);
}
test_isReferencedBy_ConstructorElement_unnamed_declared_new() async {
await _indexTestUnit('''
/// [new A] 1
class A {
A.new() {}
}
class B extends A {
B() : super(); // 2
factory B.bar() = A; // 3
}
void f() {
A(); // 4
A.new; // 5
}
''');
var element = findElement.unnamedConstructor('A');
assertThat(element)
..hasRelationCount(5)
..isReferencedAt('] 1', true, length: 0)
..isReferencedAt('(); // 2', true, length: 0)
..isReferencedAt('; // 3', true, length: 0)
..isReferencedAt('(); // 4', true, length: 0)
..isReferencedAt('.new; // 5', true, length: 4);
}
test_isReferencedBy_ConstructorElement_unnamed_synthetic() async {
await _indexTestUnit('''
/// [new A] 1
class A {}
class B extends A {
B() : super(); // 2
factory B.bar() = A; // 3
}
void f() {
A(); // 4
A.new; // 5
}
''');
var element = findElement.unnamedConstructor('A');
assertThat(element)
..hasRelationCount(5)
..isReferencedAt('] 1', true, length: 0)
..isReferencedAt('(); // 2', true, length: 0)
..isReferencedAt('; // 3', true, length: 0)
..isReferencedAt('(); // 4', true, length: 0)
..isReferencedAt('.new; // 5', true, length: 4);
}
test_isReferencedBy_DynamicElement() async {