[CFE] Remove unused fasta/sdk_test.dart

Also remove 'onlyCrashes' option which was only used there.

Change-Id: Iba1486058d561284d71aabf13431f302e7c5b9b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/346520
Reviewed-by: Johnni Winther <johnniwinther@google.com>

pkg/front_end/test/fasta/sdk_test.dart

@@ -1,19 +0,0 @@
-// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-library fasta.test.sdk_test;
-
-import 'testing/suite.dart';
-
-Future<FastaContext> createContext(
-    Chain suite, Map<String, String> environment) {
-  environment[COMPILATION_MODE] = CompileMode.full.name;
-  environment["skipVm"] ??= "true";
-  environment["onlyCrashes"] ??= "true";
-  environment["ignoreExpectations"] ??= "true";
-  return FastaContext.create(suite, environment);
-}
-
-void main([List<String> arguments = const []]) =>
-    runMe(arguments, createContext);

pkg/front_end/test/fasta/testing/suite.dart

@@ -211,7 +211,6 @@ class FastaContext extends ChainContext with MatchContext {
   @override
   final List<Step> steps;
   final Uri vm;
-  final bool onlyCrashes;
   final Map<ExperimentalFlag, bool> forcedExperimentalFlags;
   final bool skipVm;
   final bool semiFuzz;
@@ -241,7 +240,6 @@ class FastaContext extends ChainContext with MatchContext {
       this.baseUri,
       this.vm,
       this.platformBinaries,
-      this.onlyCrashes,
       this.forcedExperimentalFlags,
       bool ignoreExpectations,
       this.updateExpectations,
@@ -418,19 +416,6 @@ class FastaContext extends ChainContext with MatchContext {
     _platforms.remove(uri);
   }
 
-  @override
-  Result processTestResult(
-      TestDescription description, Result result, bool last) {
-    if (onlyCrashes) {
-      Expectation outcome = result.outcome;
-      if (outcome == Expectation.crash || outcome == verificationError) {
-        return result;
-      }
-      return result.copyWithOutcome(Expectation.pass);
-    }
-    return super.processTestResult(description, result, last);
-  }
-
   @override
   Set<Expectation> processExpectedOutcomes(
       Set<Expectation> outcomes, TestDescription description) {
@@ -473,7 +458,6 @@ class FastaContext extends ChainContext with MatchContext {
       "enableExtensionMethods",
       "enableNonNullable",
       "soundNullSafety",
-      "onlyCrashes",
       "ignoreExpectations",
       UPDATE_EXPECTATIONS,
       UPDATE_COMMENTS,
@@ -492,7 +476,6 @@ class FastaContext extends ChainContext with MatchContext {
         SuiteFolderOptions.computeForcedExperimentalFlags(environment);
 
     bool soundNullSafety = environment["soundNullSafety"] == "true";
-    bool onlyCrashes = environment["onlyCrashes"] == "true";
     bool ignoreExpectations = environment["ignoreExpectations"] == "true";
     bool updateExpectations = environment[UPDATE_EXPECTATIONS] == "true";
     bool updateComments = environment[UPDATE_COMMENTS] == "true";
@@ -509,7 +492,6 @@ class FastaContext extends ChainContext with MatchContext {
         platformBinaries == null
             ? computePlatformBinariesLocation(forceBuildDir: true)
             : Uri.base.resolve(platformBinaries),
-        onlyCrashes,
         experimentalFlags,
         ignoreExpectations,
         updateExpectations,

pkg/front_end/testing.json

@@ -333,31 +333,6 @@
       ],
       "exclude": []
     },
-    {
-      "name": "sdk",
-      "kind": "Chain",
-      "source": "test/fasta/sdk_test.dart",
-      "path": "../../tests/",
-      "status": "testcases/sdk.status",
-      "process-multitests": true,
-      "pattern": [
-        "/sdk/tests/language/.*_test\\.dart$"
-      ],
-      "": "deep_nesting{1,2}_negative_test are ignored because they cause a",
-      "": "crash that we're ignoring for now (it was fixed in Rasta).",
-      "": "The other tests are excluded because they try to use 'none' as ",
-      "": "subtest name in multi test.",
-      "": "Tracked by: https://github.com/dart-lang/sdk/issues/28436",
-      "exclude": [
-        "/sdk/tests/language/abstract_getter2_test\\.dart$",
-        "/sdk/tests/language/round_test\\.dart$",
-        "/sdk/tests/language/regress_23996_test\\.dart$",
-        "/sdk/tests/language/regress_30669_test\\.dart$",
-        "/sdk/tests/language/regress_30927_test\\.dart$",
-        "/sdk/tests/language/runtime_type_function_test\\.dart$",
-        "/sdk/tests/language/setter_override_test\\.dart$"
-      ]
-    },
     {
       "note": "Tests dart2js fully, excluding browser-only tests.",
       "name": "dart2js",

pkg/pkg.status

@@ -56,7 +56,6 @@ dev_compiler/test/worker/*: Skip # test needs fixes
 front_end/test/fasta/analyze_git_test: Pass, Slow
 front_end/test/fasta/bootstrap_test: Pass, Slow
 front_end/test/fasta/rasta/*: SkipByDesign # Anything in rasta is input to fasta unit tests and shouldn't be run as tests.
-front_end/test/fasta/sdk_test: SkipByDesign # sdk_test would take too long to complete, and should be run in a different way.
 front_end/test/fasta/types/dart2js_benchmark_test: Pass, Slow
 front_end/test/fasta/types/large_app_benchmark_test: Pass, ExtraSlow
 front_end/test/incremental_compiler_leak_test: Pass, ExtraSlow