languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:09:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tests] Ensure that --enable-asserts is used whereever checked was used previously

Browse source 
Change-Id: Ia88c03a8dd36237f3c819a3a892f8f17ecf7f00b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97604
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
This commit is contained in:
asiva 2019-03-22 19:51:41 +00:00 committed by commit-bot@chromium.org
parent a8831e7481
commit 98dddc9daa
3 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/front_end/tool/fasta
View file

@ -62,4 +62,4 @@ esac
shift
exec "${DART_VM}" "${EXTRA_VM_ARGS[@]}" "${SCRIPT}" "$@"
exec "${DART_VM}" "${EXTRA_VM_ARGS[@]}" --enable-asserts "${SCRIPT}" "$@"

2
tools/bots/test_matrix.json
View file

@ -304,7 +304,7 @@
"dartk-(linux|mac|win)-(debug|product|release)-(ia32|x64)": { },
"dartk-checked-(linux|mac|win)-(debug|product|release)-(ia32|x64)": {
"options": {
"checked": true
"enable-asserts": true
}},
"dartk-(linux|mac|win)-(debug|product|release)-(arm64|simarm|simarm64|simdbc64)": { },
"dartk-optcounter-(linux|mac|win)-(debug|product|release)-(ia32|x64)": {

6
tools/testing/dart/compiler_configuration.dart
View file

@ -798,6 +798,9 @@ class PrecompilerCompilerConfiguration extends CompilerConfiguration
List<String> ddcOptions,
List<String> originalArguments) {
List<String> args = [];
if (_useEnableAsserts) {
args.add('--enable_asserts');
}
return args
..addAll(filterVmOptions(vmOptions))
..addAll(sharedOptions)
@ -871,6 +874,9 @@ class AppJitCompilerConfiguration extends CompilerConfiguration {
List<String> computeCompilerArguments(
vmOptions, sharedOptions, dart2jsOptions, ddcOptions, originalArguments) {
var args = <String>[];
if (_useEnableAsserts) {
args.add('--enable_asserts');
}
return args
..addAll(vmOptions)
..addAll(sharedOptions)