languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 02:47:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve the highlight range for non_sized_type_argument

Browse source 
Change-Id: I1c54df8e8f5c167fdb87053cca181cd52ee6f853
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213823
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Brian Wilkerson 2021-09-20 16:50:21 +00:00 committed by commit-bot@chromium.org
parent d6f0e39f30
commit 98d28c08ee
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
pkg/analyzer/lib/src/generated/ffi_verifier.dart
View file

@ -701,8 +701,15 @@ class FfiVerifier extends RecursiveAstVisitor<void> {
} else if (declaredType.isArray) {
final typeArg = (declaredType as InterfaceType).typeArguments.single;
if (!_isSized(typeArg)) {
AstNode errorNode = fieldType;
if (fieldType is TypeName) {
var typeArguments = fieldType.typeArguments?.arguments;
if (typeArguments != null && typeArguments.isNotEmpty) {
errorNode = typeArguments[0];
}
}
_errorReporter.reportErrorForNode(FfiCode.NON_SIZED_TYPE_ARGUMENT,
fieldType, [_arrayClassName, typeArg.toString()]);
errorNode, [_arrayClassName, typeArg]);
}
final arrayDimensions = declaredType.arrayDimensions;
_validateSizeOfAnnotation(fieldType, annotations, arrayDimensions);

4
pkg/analyzer/test/src/diagnostics/non_sized_type_argument_test.dart
View file

@ -24,7 +24,7 @@ class C extends Struct {
external Array<Void> a0;
}
''', [
error(FfiCode.NON_SIZED_TYPE_ARGUMENT, 68, 11),
error(FfiCode.NON_SIZED_TYPE_ARGUMENT, 74, 4),
]);
}
@ -37,7 +37,7 @@ class C extends Union {
external Array<Void> a0;
}
''', [
error(FfiCode.NON_SIZED_TYPE_ARGUMENT, 67, 11),
error(FfiCode.NON_SIZED_TYPE_ARGUMENT, 73, 4),
]);
}