languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-08 12:06:26 +00:00
Code Issues Projects Releases Wiki Activity

[vm] Remove dead Thread::pending_functions_.

Browse Source 
Cf. c9f5c3a79e.

TEST=build
Change-Id: I9edff8afaf277b03c4dfdcdbea9ba244dde577ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213740
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak 2021-09-22 17:16:36 +00:00 committed by commit-bot@chromium.org
parent 306718fe1e
commit 9854a04210
4 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
runtime/vm/isolate.cc
View File

@ -650,7 +650,6 @@ void IsolateGroup::UnscheduleThreadLocked(MonitorLocker* ml,
thread->set_execution_state(Thread::kThreadInNative);
thread->set_safepoint_state(Thread::AtSafepointField::encode(true) |
Thread::AtDeoptSafepointField::encode(true));
thread->clear_pending_functions();
ASSERT(thread->no_safepoint_scope_depth() == 0);
if (is_mutator) {
// The mutator thread structure stays alive and attached to the isolate as

1
runtime/vm/object.cc
View File

@ -1191,7 +1191,6 @@ void Object::Init(IsolateGroup* isolate_group) {
// Some thread fields need to be reinitialized as null constants have not been
// initialized until now.
thread->ClearStickyError();
thread->clear_pending_functions();
ASSERT(!null_object_->IsSmi());
ASSERT(!null_class_->IsSmi());

13
runtime/vm/thread.cc
View File

@ -98,7 +98,6 @@ Thread::Thread(bool is_vm_isolate)
stack_overflow_count_(0),
hierarchy_info_(NULL),
type_usage_info_(NULL),
pending_functions_(GrowableObjectArray::null()),
sticky_error_(Error::null()),
REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_INITIALIZERS)
REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_SCOPE_INIT)
@ -219,17 +218,6 @@ void Thread::InitVMConstants() {
#undef REUSABLE_HANDLE_ALLOCATION
}
GrowableObjectArrayPtr Thread::pending_functions() {
if (pending_functions_ == GrowableObjectArray::null()) {
pending_functions_ = GrowableObjectArray::New(Heap::kOld);
}
return pending_functions_;
}
void Thread::clear_pending_functions() {
pending_functions_ = GrowableObjectArray::null();
}
void Thread::set_active_exception(const Object& value) {
active_exception_ = value.ptr();
}
@ -613,7 +601,6 @@ void Thread::VisitObjectPointers(ObjectPointerVisitor* visitor,
// Visit objects in thread specific handles area.
reusable_handles_.VisitObjectPointers(visitor);
visitor->VisitPointer(reinterpret_cast<ObjectPtr*>(&pending_functions_));
visitor->VisitPointer(reinterpret_cast<ObjectPtr*>(&global_object_pool_));
visitor->VisitPointer(reinterpret_cast<ObjectPtr*>(&active_exception_));
visitor->VisitPointer(reinterpret_cast<ObjectPtr*>(&active_stacktrace_));

4
runtime/vm/thread.h
View File

@ -695,9 +695,6 @@ class Thread : public ThreadState {
return OFFSET_OF(Thread, unboxed_double_runtime_arg_);
}
GrowableObjectArrayPtr pending_functions();
void clear_pending_functions();
static intptr_t global_object_pool_offset() {
return OFFSET_OF(Thread, global_object_pool_);
}
@ -1127,7 +1124,6 @@ class Thread : public ThreadState {
CompilerState* compiler_state_ = nullptr;
HierarchyInfo* hierarchy_info_;
TypeUsageInfo* type_usage_info_;
GrowableObjectArrayPtr pending_functions_;
CompilerTimings* compiler_timings_ = nullptr;