languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 20:21:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Compare error names in strong_mode_test ignoring order.

Browse source 
These tests were flaky.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2021613002 .
This commit is contained in:
Konstantin Shcheglov 2016-05-29 12:13:02 -07:00
parent fba5cbc425
commit 9820588f06
1 changed files with 17 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
pkg/analyzer/test/generated/strong_mode_test.dart
View file

@ -1795,10 +1795,12 @@ class D extends C {
errors.sort((AnalysisError e1, AnalysisError e2) =>
e1.errorCode.name.compareTo(e2.errorCode.name));
expect(errors.map((e) => e.errorCode.name), [
'INVALID_METHOD_OVERRIDE_RETURN_TYPE',
'STRONG_MODE_INVALID_METHOD_OVERRIDE'
]);
expect(
errors.map((e) => e.errorCode.name),
unorderedEquals([
'INVALID_METHOD_OVERRIDE_RETURN_TYPE',
'STRONG_MODE_INVALID_METHOD_OVERRIDE'
]));
expect(errors[0].message, contains('Iterable<S>'),
reason: 'errors should be in terms of the type parameters '
'at the error location');
@ -1818,11 +1820,12 @@ class D extends C {
// TODO(jmesserly): this is modified code from assertErrors, which we can't
// use directly because STRONG_MODE_* errors don't have working equality.
List<AnalysisError> errors = analysisContext2.computeErrors(source);
List errorNames = errors.map((e) => e.errorCode.name).toList();
expect(errorNames, hasLength(2));
expect(errorNames, contains('STRONG_MODE_INVALID_METHOD_OVERRIDE'));
expect(
errorNames, contains('INVALID_METHOD_OVERRIDE_TYPE_PARAMETER_BOUND'));
errors.map((e) => e.errorCode.name),
unorderedEquals([
'INVALID_METHOD_OVERRIDE_TYPE_PARAMETER_BOUND',
'STRONG_MODE_INVALID_METHOD_OVERRIDE'
]));
verify([source]);
}
@ -1837,10 +1840,12 @@ class D extends C {
// TODO(jmesserly): we can't use assertErrors because STRONG_MODE_* errors
// from CodeChecker don't have working equality.
List<AnalysisError> errors = analysisContext2.computeErrors(source);
expect(errors.map((e) => e.errorCode.name), [
'STRONG_MODE_INVALID_METHOD_OVERRIDE',
'INVALID_METHOD_OVERRIDE_TYPE_PARAMETERS'
]);
expect(
errors.map((e) => e.errorCode.name),
unorderedEquals([
'STRONG_MODE_INVALID_METHOD_OVERRIDE',
'INVALID_METHOD_OVERRIDE_TYPE_PARAMETERS'
]));
verify([source]);
}