languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 14:32:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Allow responses with no "type" field to succeed for ServiceExtensionConsumers.

Browse source 
Change-Id: If7f239c67e54330e77e805dd2375bbfba1dbd76c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117441
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Kenzie Schmoll <kenzieschmoll@google.com>
This commit is contained in:
Kenzie Schmoll 2019-09-17 14:42:31 +00:00 committed by commit-bot@chromium.org
parent e00c8f3cb7
commit 9753a397bf
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
pkg/vm_service/java/src/org/dartlang/vm/service/VmServiceBase.java
View file

@ -618,11 +618,13 @@ abstract class VmServiceBase implements VmServiceConst {
Logging.getLogger().logError("Response has invalid " + RESULT, e);
return;
}
String responseType;
try {
String responseType = "";
if (result.has(TYPE)) {
responseType = result.get(TYPE).getAsString();
} catch (Exception e) {
Logging.getLogger().logError("Response missing " + TYPE, e);
}
// ServiceExtensionConsumers do not care about the response type.
else if (!(consumer instanceof ServiceExtensionConsumer)) {
Logging.getLogger().logError("Response missing " + TYPE + ": " + result.toString());
return;
}
forwardResponse(consumer, responseType, result);