languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 12:14:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove dart2js non-strong platforms

Browse source 
Since dart2js is now strong-mode-only and ignores the --strong flag, I don't see the point in having 'strong' in the platform name.

Removed:
  dart2js_platform
  dart2js_server_platform
renamed:
  dart2js_platform_strong --> dart2js_platform
  dart2js_server_platform_strong --> dart2js_server_platform

Change-Id: If74ef31a17acc15a23a5338e5f53e820fc66b0dd
Reviewed-on: https://dart-review.googlesource.com/71425
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This commit is contained in:
Stephen Adams 2018-09-18 16:33:19 +00:00 committed by commit-bot@chromium.org
parent bfeb270b21
commit 96a190020e
4 changed files with 1 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/compiler/lib/src/library_loader.dart
View file

@ -56,7 +56,7 @@ class LibraryLoaderTask extends CompilerTask {
} else {
String targetName =
_options.compileForServer ? "dart2js_server" : "dart2js";
String platform = '${targetName}_platform_strong.dill';
String platform = '${targetName}_platform.dill';
initializedCompilerState = fe.initializeCompiler(
initializedCompilerState,
new Dart2jsTarget(targetName, new TargetFlags(strongMode: true)),

4
sdk/BUILD.gn
View file

@ -516,14 +516,10 @@ copy("copy_dart2js_dill_files") {
":copy_libraries",
"../utils/compiler:compile_dart2js_platform",
"../utils/compiler:compile_dart2js_server_platform",
"../utils/compiler:compile_dart2js_platform_strong",
"../utils/compiler:compile_dart2js_server_platform_strong",
]
sources = [
"$root_out_dir/dart2js_platform.dill",
"$root_out_dir/dart2js_server_platform.dill",
"$root_out_dir/dart2js_platform_strong.dill",
"$root_out_dir/dart2js_server_platform_strong.dill",
]
outputs = [
"$root_out_dir/dart-sdk/lib/_internal/{{source_file_part}}",

36
utils/compiler/BUILD.gn
View file

@ -60,14 +60,11 @@ dart_action("dart2js_create_snapshot_entry") {
application_snapshot("dart2js") {
deps = [
":compile_dart2js_platform",
":compile_dart2js_platform_strong",
":dart2js_create_snapshot_entry",
]
inputs = [
"$root_out_dir/dart2js_platform.dill",
"$root_out_dir/dart2js_outline.dill",
"$root_out_dir/dart2js_platform_strong.dill",
"$root_out_dir/dart2js_outline_strong.dill",
]
vm_args = []
main_dart = "$target_gen_dir/dart2js.dart"
@ -89,29 +86,12 @@ compile_platform("compile_dart2js_platform") {
"$root_out_dir/dart2js_outline.dill",
]
args = [
"--target=dart2js",
"dart:core",
]
}
compile_platform("compile_dart2js_platform_strong") {
single_root_scheme = "org-dartlang-sdk"
single_root_base = rebase_path("../../")
libraries_specification_uri = "org-dartlang-sdk:///sdk/lib/libraries.json"
outputs = [
"$root_out_dir/dart2js_platform_strong.dill",
"$root_out_dir/dart2js_outline_strong.dill",
]
args = [
"--target=dart2js",
"--strong",
"dart:core",
]
}
compile_platform("compile_dart2js_server_platform") {
single_root_scheme = "org-dartlang-sdk"
single_root_base = rebase_path("../../")
@ -122,22 +102,6 @@ compile_platform("compile_dart2js_server_platform") {
"$root_out_dir/dart2js_server_outline.dill",
]
args = [
"--target=dart2js_server",
"dart:core",
]
}
compile_platform("compile_dart2js_server_platform_strong") {
single_root_scheme = "org-dartlang-sdk"
single_root_base = rebase_path("../../")
libraries_specification_uri = "org-dartlang-sdk:///sdk/lib/libraries.json"
outputs = [
"$root_out_dir/dart2js_server_platform_strong.dill",
"$root_out_dir/dart2js_server_outline_strong.dill",
]
args = [
"--target=dart2js_server",
"--strong",

3
utils/dartdevc/BUILD.gn
View file

@ -83,7 +83,6 @@ template("dart2js_compile") {
dart_action(target_name) {
deps = [
"../compiler:compile_dart2js_platform",
"../compiler:compile_dart2js_platform_strong",
]
# dart_action() needs kernel service snapshot to run in Dart 2 mode.
@ -94,8 +93,6 @@ template("dart2js_compile") {
inputs = sdk_lib_files + compiler_files + dev_compiler_files + [
"$root_out_dir/dart2js_platform.dill",
"$root_out_dir/dart2js_outline.dill",
"$root_out_dir/dart2js_platform_strong.dill",
"$root_out_dir/dart2js_outline_strong.dill",
]
outputs = [
out,